[runtime/utils/buffer/append] use Blob::write_at_sync#3857
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
commonware-mcp | 837ad2f | May 22 2026, 08:23 PM |
Benchmark resultsTip ✅ PASSED: No benchmark exceeded the regression threshold. Benchmark comparison table
Baseline commit(s): |
3ad003c to
dd24c7f
Compare
Deploying monorepo with
|
| Latest commit: |
837ad2f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://465dc6ba.monorepo-eu0.pages.dev |
| Branch Preview URL: | https://andre-runtime-append-write-a.monorepo-eu0.pages.dev |
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 837ad2f. Configure here.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #3857 +/- ##
==========================================
+ Coverage 95.75% 95.77% +0.02%
==========================================
Files 486 486
Lines 200864 201251 +387
Branches 4861 4876 +15
==========================================
+ Hits 192341 192756 +415
+ Misses 6891 6860 -31
- Partials 1632 1635 +3
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This PR updates
buffer::paged::Appendto useBlob::write_at_syncwhen a flush can be persisted with a single physical write. When a flush is split around a protected CRC slot, or when a prior plain write or resize still needs a durability barrier, it falls back to plain writes followed by a single full sync. It now tracks whether prior blob mutations still need a full sync sosync()can skip work when there is nothing pending. Resize/shrink handling was adjusted so real physical resizes are made durable correctly, while logical-only partial shrinks can keep using range sync for their CRC updates.Depends on #3852.