[runtime/iobuf/pool] improve buffer pool defaults#3860
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
commonware-mcp | 05605a6 | May 22 2026, 09:08 PM |
| let cache_line = NZUsize!(cache_line_size()); | ||
| Self { | ||
| pool_min_size: 1024, | ||
| pool_min_size: 0, |
There was a problem hiding this comment.
The pool is now faster than going to the system allocator, so there's no reason to bypass it in the defaults.
| pool_min_size: 0, | ||
| min_size: NZUsize!(1024), | ||
| max_size: NZUsize!(64 * 1024), | ||
| max_size: NZUsize!(128 * 1024), |
There was a problem hiding this comment.
Why not? This means this pool will use 1GB of memory at peak, same as the storage pool below.
| max_per_class: NZU32!(4096), | ||
| prefill: false, | ||
| alignment: cache_line, | ||
| alignment: NZUsize!(1), |
There was a problem hiding this comment.
We don't actually need any specific alignment here, and while this doesn't make any difference once the buffer is allocated and pooled the initial allocation is slower.
| let page = NZUsize!(page_size()); | ||
| Self { | ||
| pool_min_size: 1024, | ||
| pool_min_size: 0, |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Deploying monorepo with
|
| Latest commit: |
05605a6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c2bb93bc.monorepo-eu0.pages.dev |
| Branch Preview URL: | https://andre-runtime-improve-pool-d.monorepo-eu0.pages.dev |
Benchmark resultsTip ✅ PASSED: No benchmark exceeded the regression threshold. Benchmark comparison table
Baseline commit(s): |
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 05605a6. Configure here.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #3860 +/- ##
==========================================
+ Coverage 95.76% 95.77% +0.01%
==========================================
Files 486 486
Lines 200680 201234 +554
Branches 4858 4876 +18
==========================================
+ Hits 192180 192741 +561
+ Misses 6866 6858 -8
- Partials 1634 1635 +1
... and 30 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
2 participants
No description provided.