Skip to content

[ci] Add Linter for Actor Blocking#3866

Draft
patrick-ogrady wants to merge 3 commits into
mainfrom
evaluate-blocking
Draft

[ci] Add Linter for Actor Blocking#3866
patrick-ogrady wants to merge 3 commits into
mainfrom
evaluate-blocking

Conversation

@patrick-ogrady
Copy link
Copy Markdown
Contributor

@patrick-ogrady patrick-ogrady commented May 23, 2026

No description provided.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 23, 2026 •
edited
Loading

Deploying monorepo with  Cloudflare Pages  Cloudflare Pages

Latest commit: 994b6df
Status: ✅  Deploy successful!
Preview URL: https://b85717cd.monorepo-eu0.pages.dev
Branch Preview URL: https://evaluate-blocking.monorepo-eu0.pages.dev

View logs

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 23, 2026 •
edited
Loading

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs		 commonware-mcp 994b6df May 24 2026, 04:47 AM

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 23, 2026 •
edited
Loading

Benchmark results

Tip

✅ PASSED: No benchmark exceeded the regression threshold.

Benchmark comparison table
Benchmark Baseline (main) Current Delta Threshold Status
qmdb::merkleize/variant=any::unordered::fixed::mmr keys=10000 ch=false sync=false 1.600 ms 1.621 ms +1.35% 10.00% ✅ PASS
qmdb::merkleize/variant=current::ordered::fixed::mmb chunk=256 keys=10000 ch=true sync=false 3.090 ms 3.109 ms +0.62% 10.00% ✅ PASS

Baseline commit(s): aa5cac3f9e23

patrick-ogrady
patrick-ogrady commented May 23, 2026
View reviewed changes
Comment thread p2p/src/authenticated/discovery/actors/listener.rs Outdated
let (peer, send, recv) = match listen(
context,
|peer| tracker.acceptable(peer),
|peer| {
Copy link
Copy Markdown
Contributor Author

@patrick-ogrady patrick-ogrady May 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem like this avoids the issue?

@codecov
Copy link
Copy Markdown

codecov Bot commented May 24, 2026

Codecov Report

❌ Patch coverage is 93.73259% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.78%. Comparing base (aa5cac3) to head (994b6df).

Files with missing lines Patch % Lines
consensus/src/marshal/standard/inline.rs 70.00% 4 Missing and 2 partials ⚠️
consensus/src/marshal/coding/marshaled.rs 20.00% 1 Missing and 3 partials ⚠️
p2p/src/utils/mod.rs 50.00% 4 Missing ⚠️
broadcast/src/buffered/engine.rs 0.00% 2 Missing and 1 partial ⚠️
consensus/src/marshal/coding/shards/engine.rs 90.90% 2 Missing and 1 partial ⚠️
consensus/src/marshal/standard/deferred.rs 85.00% 0 Missing and 3 partials ⚠️
p2p/src/authenticated/discovery/actors/dialer.rs 93.61% 2 Missing and 1 partial ⚠️
p2p/src/authenticated/lookup/actors/dialer.rs 93.61% 2 Missing and 1 partial ⚠️
resolver/src/p2p/engine.rs 0.00% 2 Missing and 1 partial ⚠️
consensus/src/aggregation/mocks/reporter.rs 66.66% 2 Missing ⚠️
... and 8 more 
@@            Coverage Diff             @@
##             main    #3866      +/-   ##
==========================================
- Coverage   95.78%   95.78%   -0.01%     
==========================================
  Files         487      487              
  Lines      201747   201874     +127     
  Branches     4885     4894       +9     
==========================================
+ Hits       193246   193367     +121     
+ Misses       6862     6859       -3     
- Partials     1639     1648       +9
Files with missing lines Coverage Δ
broadcast/src/buffered/ingress.rs 98.21% <100.00%> (ø)
collector/src/p2p/engine.rs 85.71% <100.00%> (+0.36%) ⬆️
collector/src/p2p/mocks/handler.rs 100.00% <100.00%> (ø)
collector/src/p2p/mocks/monitor.rs 100.00% <100.00%> (ø)
consensus/src/aggregation/mod.rs 98.67% <100.00%> (ø)
consensus/src/marshal/application/validation.rs 100.00% <100.00%> (ø)
consensus/src/marshal/coding/shards/mailbox.rs 96.15% <100.00%> (+0.11%) ⬆️
consensus/src/marshal/coding/variant.rs 95.52% <100.00%> (ø)
consensus/src/marshal/core/mailbox.rs 92.74% <100.00%> (+0.02%) ⬆️
consensus/src/marshal/mocks/harness.rs 98.80% <100.00%> (ø)
... and 41 more

... and 11 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa5cac3...994b6df. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@patrick-ogrady patrick-ogrady

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@patrick-ogrady