Skip to content

[consensus] Improve "Old" Message Handling#713

Closed
patrick-ogrady wants to merge 9 commits into
mainfrom
old-view
Closed

[consensus] Improve "Old" Message Handling#713
patrick-ogrady wants to merge 9 commits into
mainfrom
old-view

Conversation

@patrick-ogrady
Copy link
Copy Markdown
Contributor

@patrick-ogrady patrick-ogrady commented Apr 11, 2025

Related: #712

TODO:

  • Standardize placement of interesting() check
  • Why call notify() if not an interesting view?
  • Should we just log (and drop) in journal for writing before pruned?
  • Add view() to some trait implemented by all types (call interesting on this)

@patrick-ogrady patrick-ogrady mentioned this pull request Apr 13, 2025
9 tasks
@patrick-ogrady
Copy link
Copy Markdown
Contributor Author

patrick-ogrady commented Apr 13, 2025

Incorporated into #675

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2025

Codecov Report

Attention: Patch coverage is 94.91525% with 27 lines in your changes missing coverage. Please review.

Project coverage is 88.71%. Comparing base (e44902f) to head (60e658b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
consensus/src/threshold_simplex/mocks/outdated.rs 89.55% 14 Missing ⚠️
consensus/src/threshold_simplex/mod.rs 94.16% 8 Missing ⚠️
...onsensus/src/threshold_simplex/actors/voter/mod.rs 98.79% 3 Missing ⚠️
...sensus/src/threshold_simplex/actors/voter/actor.rs 80.00% 2 Missing ⚠️
@@            Coverage Diff             @@
##             main     #713      +/-   ##
==========================================
+ Coverage   88.55%   88.71%   +0.16%     
==========================================
  Files         160      163       +3     
  Lines       38654    39391     +737     
==========================================
+ Hits        34230    34947     +717     
- Misses       4424     4444      +20     
Files with missing lines Coverage Δ
...s/src/threshold_simplex/actors/resolver/ingress.rs 100.00% <100.00%> (ø)
...nsus/src/threshold_simplex/actors/voter/ingress.rs 100.00% <100.00%> (ø)
...sensus/src/threshold_simplex/actors/voter/actor.rs 93.82% <80.00%> (+0.28%) ⬆️
...onsensus/src/threshold_simplex/actors/voter/mod.rs 98.79% <98.79%> (ø)
consensus/src/threshold_simplex/mod.rs 93.53% <94.16%> (+0.04%) ⬆️
consensus/src/threshold_simplex/mocks/outdated.rs 89.55% <89.55%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e44902f...60e658b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BrendanChou BrendanChou deleted the old-view branch June 18, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant