[consensus] codec migration (Attempt 2)

[patrick-ogrady]

Replaces: #675
Resolves: #444
Replaces: #462
Related: #707
Resolves: #712

TODO

• migrate threshold-simplex
  • Move sign operations to types: [consensus/threshold-simplex] Add sign() #742
  • Populate comments in types (from wire.proto): [consensus/types] Add comments #766
  • Accept structured types in conflicting::new (like simplex): [consensus] Remove Duplicate Data from Conflicting Encoding #763
• migrate simplex: [consensus] Migrate simplex #743
  • Populate comments in types (from wire.proto): [consensus/types] Add comments #766
  • Enforce uniqueness by requiring sorted signatures (rather than using a map of pubkeys): [consensus] Remove Duplicate Data from Conflicting Encoding #763
• migrate ordered-broadcast: [consensus] Migrate ordered-broadcast #737
• Examples passing: [examples] Passing #758
• Move namespacing into types (avoid tracking different namespaces in the verify/signer caller): [consensus] Simplify namespace Usage #761
• Dedup data in conflicting activity encoding: [consensus] Remove Duplicate Data from Conflicting Encoding #763
• Test modified examples
• Encode both u32 and u64 as varint: [consensus] Use varint for all number encoding #765
• Use union_unique: [utils] Review usage of union vs union_unique #759
• Add Proposal activity to simplex and threshold-simplex: [consensus/simplex + threshold-simplex] Emit Proposal Activity (like ordered-broadcast) after Verification #767
• Use HashMap for Nullify (because sort in Types) -> or use BtreeSet everywhere: [consensus] codec Migration Nits #772
• Use Iterator instead of IntoIterator: [cryptography/bls12381] Review Whether We Should Use Iterator instead of IntoIterator #773

[Copilot]

Pull Request Overview

This pull request migrates several consensus components to use the new codec “types” and updates the generics by replacing the Array constraints with Digest where appropriate. Key changes include refactoring of the simplex resolver actor, removal of legacy proto-based modules (wire.proto, parsed, serializer, prover, namespace), and a renaming of committers to reporters in the ordered broadcast module and associated mocks and configuration.

Reviewed Changes

Copilot reviewed 72 out of 72 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
consensus/src/simplex/actors/resolver/actor.rs	Updated to use structured types, replaced deprecated namespace functions, and adjusted generic bounds (Array → Digest).
consensus/src/ordered_broadcast/*	Removed legacy proto definitions and related modules; updated usage to reference new types and shifted from Scheme to Verifier where applicable.
Various mocks and config files	Transition from using Committer to Reporter along with corresponding test updates.
consensus/src/ordered_broadcast/ack_manager.rs	Updated the ack aggregation to use the new signature field and adjusted generic parameter ordering.
consensus/build.rs & Cargo.toml	Removed build dependencies for the obsolete proto files and adjusted dependency declarations.

Comments suppressed due to low confidence (3)

consensus/src/ordered_broadcast/ack_manager.rs:75

• The change from using 'ack.partial.index' to 'ack.signature.index' assumes that all Ack objects are constructed with a valid signature field. Please verify that all Ack producers have been updated accordingly to prevent potential mismatches.

if (!p.shares.insert(ack.signature.index)) {

consensus/src/ordered_broadcast/wire.proto:1

• The entire 'wire.proto' file has been removed. Please ensure that no lingering dependencies or build scripts rely on this file to avoid integration issues.

syntax = "proto3";

consensus/src/ordered_broadcast/mocks/reporter.rs:1

• [nitpick] With the migration from Committer to Reporter in mocks, please double-check that all tests cover the new Reporter flow and any behavioral differences that may impact consensus reporting.

use crate::{ordered_broadcast::types::{Activity, Chunk, Epoch, Lock, Proposal}, Reporter as Z};

[BrendanChou]

To prevent writing these functions twice, should we have one be the primary (say Debug) and have Display call Debug::fmt(self, f)?

[patrick-ogrady]

This is a pattern I adapted from elsewhere in cryptography. Happy to migrate to a shared implementation but think we should do all at once.

[BrendanChou]

None of my comments are blocking, feel free to merge

[patrick-ogrady]

Nits addressed here: #772

[codecov]

Codecov Report

Attention: Patch coverage is 94.47589% with 283 lines in your changes missing coverage. Please review.

Project coverage is 89.37%. Comparing base (5a14fd6) to head (0b9ae71).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
consensus/src/simplex/types.rs	88.55%	128 Missing ⚠️
consensus/src/simplex/actors/voter/actor.rs	93.50%	28 Missing ⚠️
...sensus/src/threshold_simplex/actors/voter/actor.rs	93.75%	24 Missing ⚠️
consensus/src/ordered_broadcast/types.rs	97.97%	19 Missing ⚠️
...onsensus/src/threshold_simplex/mocks/supervisor.rs	89.47%	16 Missing ⚠️
consensus/src/simplex/mod.rs	97.30%	14 Missing ⚠️
consensus/src/threshold_simplex/mod.rs	97.24%	14 Missing ⚠️
consensus/src/simplex/mocks/supervisor.rs	94.37%	9 Missing ⚠️
consensus/src/ordered_broadcast/mocks/reporter.rs	89.06%	7 Missing ⚠️
consensus/src/simplex/actors/resolver/actor.rs	86.11%	5 Missing ⚠️
... and 6 more

@@            Coverage Diff             @@
##             main     #735      +/-   ##
==========================================
+ Coverage   88.84%   89.37%   +0.53%     
==========================================
  Files         168      165       -3     
  Lines       40198    41293    +1095     
==========================================
+ Hits        35714    36907    +1193     
+ Misses       4484     4386      -98     

Files with missing lines	Coverage Δ
consensus/src/ordered_broadcast/ack_manager.rs	100.00% <100.00%> (ø)
consensus/src/ordered_broadcast/mocks/automaton.rs	94.87% <ø> (ø)
consensus/src/ordered_broadcast/mocks/monitor.rs	100.00% <ø> (ø)
...onsensus/src/ordered_broadcast/mocks/sequencers.rs	75.00% <ø> (+6.81%)	⬆️
...onsensus/src/ordered_broadcast/mocks/validators.rs	86.66% <ø> (+5.41%)	⬆️
consensus/src/ordered_broadcast/mod.rs	99.33% <100.00%> (+0.01%)	⬆️
consensus/src/ordered_broadcast/tip_manager.rs	100.00% <100.00%> (ø)
consensus/src/simplex/actors/resolver/ingress.rs	100.00% <100.00%> (ø)
consensus/src/simplex/actors/voter/ingress.rs	100.00% <100.00%> (ø)
consensus/src/simplex/config.rs	68.57% <ø> (+0.15%)	⬆️
... and 29 more

... and 6 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a14fd6...0b9ae71. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.