[PMG Post Install] Nag Request on PMG when using mobile devices (again)

[frontend-report]

Script: PMG Post Install

Reported by: @doog1605

Guidelines

• Read and understood guidelines: yes
• Verbose mode used: yes

Issue occurs during: Initial Creation / Installation

Environment

• Linux distribution: Debian
• Proxmox version: 9.1
• Default settings: No
• Advanced settings: Yes
• Exact command: bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/tools/pve/post-pmg-install.sh)"

Description

Nag Request strikes again while using mobile devices.

Looks like sed patch is no more fixing the problem since subscription handling was moved to pmg-mobile-quarantine-ui_bg.wasm.

See:

{ zcat /usr/share/pmg-mobile-quarantine-ui/pmg-mobile-quarantine-ui_bg.wasm.gz 2>/dev/null || cat pmg-mobile-quarantine-ui_bg.wasm 2>/dev/null; } | strings | grep -iE 'no valid|subscription|active'

PMG version is 9.1.2.

Steps to reproduce

Click a link in the quarantine report while using a mobile device or switch to mobile.

Error output

No valid subscription

You do not have a valid subscription for this server. Please visit www.proxmox.com to get a list of available options.

Attachments

[MickLesk]

i had try to reproduce it - no way at my system. (fresh deployed and executed post-setup, because i dont use pmg) did you cleared cache of your mobile device?

[doog1605]

i had try to reproduce it - no way at my system. (fresh deployed and executed post-setup, because i dont use pmg) did you cleared cache of your mobile device?

The post-install script was executed well before I opened Quarantine for the first time, so I don't think there was any need to clear the cache.

I also verified the behavior in three different desktop browsers, since it's possible to switch between the desktop and mobile views.

The nag handling now differs between the desktop and mobile pages. The desktop implementation remains unchanged, but the mobile implementation has been moved to pmg-mobile-quarantine-ui_bg.wasm. As a result, sed can no longer find its target and fails silently, leaving the mobile pages unpatched.

[MickLesk]

OK. It’s not relevant to me at the moment, as I don’t use it, and the mobile themes by yew are always a bit of a faff to patch. I’ll put it right at the bottom of my list for now; if I ever have too much time on my hands, I might have a look at it.