Skip to content

Commit 46aa5ca

Browse files
Keeping wiki link when not showing caught
The recent `FishSeet` modifications inadvertently hid the link to the wiki page when hiding buttons to set caught/uncaught state. This has been fixed.
1 parent c54f5b2 commit 46aa5ca

1 file changed

Lines changed: 24 additions & 25 deletions

File tree

apps/stardew.app/src/components/sheets/fish-sheet.tsx

Lines changed: 24 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -106,10 +106,10 @@ export const FishSheet = ({
106106
const content = (
107107
<>
108108
<div className="mt-4 space-y-6">
109-
{showCaught && (
110-
<section className="space-y-2">
111-
<div className="grid grid-cols-1 gap-2">
112-
{selectedItems.size > 0 ? (
109+
<section className="space-y-2">
110+
<div className="grid grid-cols-1 gap-2">
111+
{showCaught &&
112+
(selectedItems.size > 0 ? (
113113
<>
114114
<Button
115115
variant="secondary"
@@ -158,27 +158,26 @@ export const FishSheet = ({
158158
</Button>
159159
)}
160160
</>
161-
)}
162-
{!activePlayer && <CreatePlayerRedirect />}
163-
{name && (
164-
<Button variant="outline" data-umami-event="Visit wiki" asChild>
165-
<a
166-
className="flex items-center"
167-
target="_blank"
168-
rel="noreferrer"
169-
href={`https://stardewvalleywiki.com/${name.replaceAll(
170-
" ",
171-
"_",
172-
)}`}
173-
>
174-
Visit Wiki Page
175-
<IconExternalLink className="h-4"></IconExternalLink>
176-
</a>
177-
</Button>
178-
)}
179-
</div>
180-
</section>
181-
)}
161+
))}
162+
{showCaught && !activePlayer && <CreatePlayerRedirect />}
163+
{name && (
164+
<Button variant="outline" data-umami-event="Visit wiki" asChild>
165+
<a
166+
className="flex items-center"
167+
target="_blank"
168+
rel="noreferrer"
169+
href={`https://stardewvalleywiki.com/${name.replaceAll(
170+
" ",
171+
"_",
172+
)}`}
173+
>
174+
Visit Wiki Page
175+
<IconExternalLink className="h-4"></IconExternalLink>
176+
</a>
177+
</Button>
178+
)}
179+
</div>
180+
</section>
182181
{fish && (
183182
<>
184183
<section className="space-y-2">

0 commit comments

Comments
 (0)