Merge pull request #282 from companieshouse/ncs-751-date-of-appointment

ncs-751 - add date of appointment to psc

Author: CHJSkinner

src/services/confirmation-statement/service.ts

@@ -330,6 +330,7 @@ export default class {
                 ...(pscResource.address && { address: this.mapToAddress(pscResource.address) }),
                 ...(pscResource.service_address && { serviceAddress: this.mapToAddress(pscResource.service_address) }),
                 appointmentType: pscResource.appointment_type,
+                appointmentDate: pscResource.appointment_date,
                 naturesOfControl: pscResource.natures_of_control,
                 dateOfBirth: pscResource.date_of_birth,
                 dateOfBirthIso: pscResource.date_of_birth_iso,
@@ -366,6 +367,7 @@ export default class {
                 ...(psc.address && { address: this.mapToAddressResource(psc.address) }),
                 ...(psc.serviceAddress && { service_address: this.mapToAddressResource(psc.serviceAddress) }),
                 appointment_type: psc.appointmentType,
+                appointment_date: psc.appointmentDate,
                 natures_of_control: psc.naturesOfControl,
                 date_of_birth: psc.dateOfBirth,
                 date_of_birth_iso: psc.dateOfBirthIso,

src/services/confirmation-statement/types.ts

@@ -193,7 +193,8 @@ export interface PersonOfSignificantControl {
     nameElements?: NameElements;
     address?: Address;
     serviceAddress?: Address;
-    appointmentType: string
+    appointmentType: string;
+    appointmentDate: string;
     naturesOfControl?: string[];
     dateOfBirth?: DateOfBirth;
     dateOfBirthIso?: string,
@@ -235,7 +236,8 @@ export interface PersonOfSignificantControlResource {
     name_elements?: NameElementsResource;
     address?: AddressResource;
     service_address?: AddressResource;
-    appointment_type: string
+    appointment_type: string;
+    appointment_date: string;
     natures_of_control?: string[];
     date_of_birth?: DateOfBirth;
     date_of_birth_iso?: string,

test/services/confirmation-statement/confirmation.statement.mock.ts

@@ -113,6 +113,7 @@ export const mockPersonsWithSignificantControlList: PersonOfSignificantControlRe
         address: mockAddress1,
         service_address: mockAddress2,
         appointment_type: "1",
+        appointment_date: "2006-04-25",
         natures_of_control: [],
         date_of_birth: {
             month: 1,
@@ -138,6 +139,7 @@ export const mockPersonsWithSignificantControlList: PersonOfSignificantControlRe
         address: mockAddress2,
         service_address: mockAddress1,
         appointment_type: "1",
+        appointment_date: "2006-04-25",
         natures_of_control: undefined,
         date_of_birth: {
             month: 1,
@@ -156,6 +158,7 @@ export const mockPersonsWithSignificantControlList: PersonOfSignificantControlRe
 export const mockPscNoNameNoAddress: PersonOfSignificantControlResource[] = [
     {
         appointment_type: "1",
+        appointment_date: "2006-04-25",
         natures_of_control: [],
         date_of_birth: {
             month: 1,