Merge pull request #6 from companieshouse/feature/fix-linting

nabeelamirch · web-flow · commit 0d40b2672ff1 · 2020-10-07T13:19:32.000+01:00
fix linting errors
diff --git a/src/client.ts b/src/client.ts
@@ -13,7 +13,7 @@ export default class ApiClient {
   public readonly lateFilingPenalties: LateFilingPenaltyService;
   public readonly companyOfficers: CompanyOfficersService;
   public readonly companyProfile: CompanyProfileService;
-   public  readonly  companyPsc : CompanyPscService ;
+   public readonly companyPsc : CompanyPscService ;
   public readonly certificate: CertificateService;
   public readonly certifiedCopies: CertifiedCopiesService;
   public readonly basket: BasketService;
diff --git a/src/services/company-psc/service.ts b/src/services/company-psc/service.ts
@@ -14,7 +14,7 @@ export default class CompanyPscService {
    *
    * @param number the company number to look up
    */
-    public async getCompanyPsc(number: string): Promise<Resource<CompanyPersonsWithSignificantControl>> {
+    public async getCompanyPsc (number: string): Promise<Resource<CompanyPersonsWithSignificantControl>> {
         const resp = await this.client.httpGet(`/company/${number}/persons-with-significant-control`);
 
         const resource: Resource<CompanyPersonsWithSignificantControl> = {
diff --git a/src/services/order/mid/mapping.ts b/src/services/order/mid/mapping.ts
@@ -1,11 +1,12 @@
-import { 
-    MidItemResource, 
-    MidItemPostRequest, 
-    MidItemRequestResource, 
-    ItemOptionsRequest, 
-    MidItem, 
-    ItemOptionsResource, 
-    ItemCostsResource } from "./types";
+import {
+    MidItemResource,
+    MidItemPostRequest,
+    MidItemRequestResource,
+    ItemOptionsRequest,
+    MidItem,
+    ItemOptionsResource,
+    ItemCostsResource
+} from "./types";
 
 export default class MidMapping {
     public static mapMidItemRequestToMidItemRequestResource (midItemRequest: MidItemPostRequest): MidItemRequestResource {
diff --git a/src/services/order/mid/service.ts b/src/services/order/mid/service.ts
@@ -24,7 +24,6 @@ export default class {
     };
 
     public async postMid (midItemRequest: MidItemPostRequest): Promise<Resource<MidItem>> {
-
         const midItemRequestResource: MidItemRequestResource = MidMapping.mapMidItemRequestToMidItemRequestResource(midItemRequest);
         const resp = await this.client.httpPost("/orderable/missing-image-deliveries", midItemRequestResource);
 
diff --git a/src/services/payment/service.ts b/src/services/payment/service.ts
@@ -49,7 +49,7 @@ export default class PaymentService {
         return this.handlePaymentHttpResponse(resp);
     }
 
-    private handlePaymentHttpResponse(resp: HttpResponse): ApiResult<ApiResponse<Payment>> {
+    private handlePaymentHttpResponse (resp: HttpResponse): ApiResult<ApiResponse<Payment>> {
         const response: ApiResponse<Payment> = {
             httpStatusCode: resp.status,
             headers: resp.headers
diff --git a/test/services/company-psc/service.spec.ts b/test/services/company-psc/service.spec.ts
@@ -46,40 +46,40 @@ describe("company-psc", () => {
                 self: "company/123/persons-with-significant-control"
             },
             items: [
-              {
-                natures_of_control: [
-                  "ownership-of-shares-25-to-50-percent-as-person"
-                ],
-                name: "James Potter",
-                links: {
-                  self: "/company/123/persons-with-significant-control/individual/L2m6DxTJA0pkUNh9SIcJY8_cdWE"
-                },
-                etag: "fe416d8a3e09c93eb961ad89b0c606982c3c01e1",
-                name_elements: {
-                  forename: "James",
-                  surname: "Potter"
-                },
-                nationality: "British",
-                country_of_residence: "Wales",
-                address: {
-                  postal_code: "CF14 3UZ",
-                  locality: "Cardiff",
-                  region: "South Glamorgan",
-                  address_line_1: "Crown Way"
-                },
-                notified_on: "2016-01-01",
-                date_of_birth: {
-                  year: "1981",
-                  month: "4"
-                },
-                identification: {
-                  country_registered: "Wales",
-                  legal_authority: "Wales",
-                  legal_form: "Public Limited Company",
-                  place_registered: "Companies House",
-                  registration_number: "INC08394823"
+                {
+                    natures_of_control: [
+                        "ownership-of-shares-25-to-50-percent-as-person"
+                    ],
+                    name: "James Potter",
+                    links: {
+                        self: "/company/123/persons-with-significant-control/individual/L2m6DxTJA0pkUNh9SIcJY8_cdWE"
+                    },
+                    etag: "fe416d8a3e09c93eb961ad89b0c606982c3c01e1",
+                    name_elements: {
+                        forename: "James",
+                        surname: "Potter"
+                    },
+                    nationality: "British",
+                    country_of_residence: "Wales",
+                    address: {
+                        postal_code: "CF14 3UZ",
+                        locality: "Cardiff",
+                        region: "South Glamorgan",
+                        address_line_1: "Crown Way"
+                    },
+                    notified_on: "2016-01-01",
+                    date_of_birth: {
+                        year: "1981",
+                        month: "4"
+                    },
+                    identification: {
+                        country_registered: "Wales",
+                        legal_authority: "Wales",
+                        legal_form: "Public Limited Company",
+                        place_registered: "Companies House",
+                        registration_number: "INC08394823"
+                    }
                 }
-              }
             ]
         });
 
diff --git a/test/services/mid/service.spec.ts b/test/services/mid/service.spec.ts
@@ -101,7 +101,7 @@ describe("create a MID POST", () => {
 });
 
 describe("GET missing image delivery", () => {
-    before(() => {
+    beforeEach(() => {
         sinon.reset();
         sinon.restore();
     });
@@ -118,7 +118,7 @@ describe("GET missing image delivery", () => {
             error: "An error occured"
         };
 
-        const mockRequest = sinon.stub(requestClient, "httpGet"). resolves(mockGetResponse);
+        const mockRequest = sinon.stub(requestClient, "httpGet").resolves(mockGetResponse);
         const missingImageDelivery: MidService = new MidService(requestClient);
         const data = await missingImageDelivery.getMid("MID-ID-NOT-IMPORTANT");
 
diff --git a/test/services/payment/service.spec.ts b/test/services/payment/service.spec.ts
@@ -120,62 +120,62 @@ describe("payment service", () => {
     });
 
     describe("get payment", () => {
-      beforeEach(() => {
-          sinon.reset();
-          sinon.restore();
-      });
-
-      afterEach(done => {
-          sinon.reset();
-          sinon.restore();
-          done();
-      });
-
-      it("returns an error response on failure", async () => {
-          const mockGetResponse = {
-              status: 401,
-              error: "An error occurred"
-          };
-
-          sinon.stub(requestClient, "httpGet").resolves(mockGetResponse);
-          const paymentService: PaymentService = new PaymentService(requestClient);
-          const response = await paymentService.getPayment("payments/TEST_ID");
-          const data = response.value as ApiResponse<Payment>;
-
-          expect(data.resource).to.be.undefined;
-      });
-
-      it("maps the payment fields", async () => {
-          const mockGetResponse = {
-              status: 200,
-              body: mockResponseBody
-          };
-
-          sinon.stub(requestClient, "httpGet").resolves(mockGetResponse);
-          const paymentService: PaymentService = new PaymentService(requestClient);
-          const response = await paymentService.getPayment("payments/TEST_ID");
-
-          const data = response.value as ApiResponse<Payment>;
-          const payment = data.resource;
-          expect(payment.amount).to.equal(mockResponseBody.amount);
-          expect(payment.availablePaymentMethods[0]).to.equal(mockResponseBody.available_payment_methods[0]);
-          expect(payment.availablePaymentMethods[1]).to.equal(mockResponseBody.available_payment_methods[1]);
-          expect(payment.companyNumber).to.equal(mockResponseBody.company_number);
-          expect(payment.completedAt).to.equal(mockResponseBody.completed_at);
-          expect(payment.createdAt).to.equal(mockResponseBody.created_at);
-          expect(payment.createdBy.email).to.equal(mockResponseBody.created_by.email);
-          expect(payment.createdBy.forename).to.equal(mockResponseBody.created_by.forename);
-          expect(payment.createdBy.id).to.equal(mockResponseBody.created_by.id);
-          expect(payment.createdBy.surname).to.equal(mockResponseBody.created_by.surname);
-          expect(payment.description).to.equal(mockResponseBody.description);
-          expect(payment.etag).to.equal(mockResponseBody.etag);
-          expect(payment.kind).to.equal(mockResponseBody.kind);
-          expect(payment.links.journey).to.equal(mockResponseBody.links.journey);
-          expect(payment.links.resource).to.equal(mockResponseBody.links.resource);
-          expect(payment.links.self).to.equal(mockResponseBody.links.self);
-          expect(payment.paymentMethod).to.equal(mockResponseBody.payment_method);
-          expect(payment.reference).to.equal(mockResponseBody.reference);
-          expect(payment.status).to.equal(mockResponseBody.status);
-      });
-  });
+        beforeEach(() => {
+            sinon.reset();
+            sinon.restore();
+        });
+
+        afterEach(done => {
+            sinon.reset();
+            sinon.restore();
+            done();
+        });
+
+        it("returns an error response on failure", async () => {
+            const mockGetResponse = {
+                status: 401,
+                error: "An error occurred"
+            };
+
+            sinon.stub(requestClient, "httpGet").resolves(mockGetResponse);
+            const paymentService: PaymentService = new PaymentService(requestClient);
+            const response = await paymentService.getPayment("payments/TEST_ID");
+            const data = response.value as ApiResponse<Payment>;
+
+            expect(data.resource).to.be.undefined;
+        });
+
+        it("maps the payment fields", async () => {
+            const mockGetResponse = {
+                status: 200,
+                body: mockResponseBody
+            };
+
+            sinon.stub(requestClient, "httpGet").resolves(mockGetResponse);
+            const paymentService: PaymentService = new PaymentService(requestClient);
+            const response = await paymentService.getPayment("payments/TEST_ID");
+
+            const data = response.value as ApiResponse<Payment>;
+            const payment = data.resource;
+            expect(payment.amount).to.equal(mockResponseBody.amount);
+            expect(payment.availablePaymentMethods[0]).to.equal(mockResponseBody.available_payment_methods[0]);
+            expect(payment.availablePaymentMethods[1]).to.equal(mockResponseBody.available_payment_methods[1]);
+            expect(payment.companyNumber).to.equal(mockResponseBody.company_number);
+            expect(payment.completedAt).to.equal(mockResponseBody.completed_at);
+            expect(payment.createdAt).to.equal(mockResponseBody.created_at);
+            expect(payment.createdBy.email).to.equal(mockResponseBody.created_by.email);
+            expect(payment.createdBy.forename).to.equal(mockResponseBody.created_by.forename);
+            expect(payment.createdBy.id).to.equal(mockResponseBody.created_by.id);
+            expect(payment.createdBy.surname).to.equal(mockResponseBody.created_by.surname);
+            expect(payment.description).to.equal(mockResponseBody.description);
+            expect(payment.etag).to.equal(mockResponseBody.etag);
+            expect(payment.kind).to.equal(mockResponseBody.kind);
+            expect(payment.links.journey).to.equal(mockResponseBody.links.journey);
+            expect(payment.links.resource).to.equal(mockResponseBody.links.resource);
+            expect(payment.links.self).to.equal(mockResponseBody.links.self);
+            expect(payment.paymentMethod).to.equal(mockResponseBody.payment_method);
+            expect(payment.reference).to.equal(mockResponseBody.reference);
+            expect(payment.status).to.equal(mockResponseBody.status);
+        });
+    });
 });

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@ export default class CompanyPscService {`
`14`	`14`	`*`
`15`	`15`	`* @param number the company number to look up`
`16`	`16`	`*/`
`17`		`- public async getCompanyPsc(number: string): Promise<Resource<CompanyPersonsWithSignificantControl>> {`
	`17`	`+ public async getCompanyPsc (number: string): Promise<Resource<CompanyPersonsWithSignificantControl>> {`
`18`	`18`	const resp = await this.client.httpGet(`/company/${number}/persons-with-significant-control`);
`19`	`19`
`20`	`20`	`const resource: Resource<CompanyPersonsWithSignificantControl> = {`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ export default class PaymentService {`
`49`	`49`	`return this.handlePaymentHttpResponse(resp);`
`50`	`50`	`}`
`51`	`51`
`52`		`- private handlePaymentHttpResponse(resp: HttpResponse): ApiResult<ApiResponse<Payment>> {`
	`52`	`+ private handlePaymentHttpResponse (resp: HttpResponse): ApiResult<ApiResponse<Payment>> {`
`53`	`53`	`const response: ApiResponse<Payment> = {`
`54`	`54`	`httpStatusCode: resp.status,`
`55`	`55`	`headers: resp.headers`