Skip to content

Commit 175b75a

Browse files
authored
Merge pull request #831 from companieshouse/fix/psc-extensions-errors
Fixing Issues
2 parents 6ef398d + 9585c35 commit 175b75a

File tree

2 files changed

+28
-7
lines changed

2 files changed

+28
-7
lines changed

src/services/psc-extensions-link/service.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { PscExtension, PscExtensionnData } from "./types"
1+
import { PscExtension, PscExtensionData } from "./types"
22

33
import { Headers, HttpResponse, IHttpClient } from "../../http";
44
import Resource, { ApiErrorResponse } from "../resource";
@@ -22,7 +22,7 @@ export default class PscExtensionService {
2222
* - A `Resource<PscExtension>` object containing the created PSC extension details.
2323
* - An `ApiErrorResponse` object if an error occurs during the request.
2424
*/
25-
public async postPscExtension (transactionId: string, pscExtension: PscExtensionnData, headers?: Headers): Promise<Resource<PscExtension> | ApiErrorResponse> {
25+
public async postPscExtension (transactionId: string, pscExtension: PscExtensionData, headers?: Headers): Promise<Resource<PscExtension> | ApiErrorResponse> {
2626
const resourceUri = `/transactions/${transactionId}/persons-with-significant-control-extensions`;
2727
const pscExtensionResource = Mapping.snakeCaseKeys(pscExtension);
2828
const response = await this.client.httpPost(resourceUri, pscExtensionResource, headers);

src/services/psc-extensions-link/types.ts

Lines changed: 26 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -110,14 +110,14 @@ export interface NameElements {
110110
surname: string;
111111
};
112112

113-
export interface PscVerificationResource {
113+
export interface PscExtensionResource {
114114
created_at: Date,
115115
updated_at: Date,
116116
links: LinksResource,
117-
data: PscExtensionnDataResource;
117+
data: PscExtensionDataResource;
118118
}
119119

120-
export interface PscExtensionnDataResource {
120+
export interface PscExtensionDataResource {
121121
company_number?: string,
122122
psc_notification_id?: string,
123123
extensionDetails?: ExtensionDetailsResource
@@ -127,9 +127,9 @@ export interface PscExtension {
127127
createdAt: Date,
128128
updatedAt: Date,
129129
links: Links,
130-
data: PscExtensionnData;
130+
data: PscExtensionData;
131131
}
132-
export interface PscExtensionnData {
132+
export interface PscExtensionData {
133133
companyNumber?: string,
134134
pscNotificationId?: string,
135135
extensionDetails?: ExtensionDetails
@@ -146,3 +146,24 @@ export interface ExtensionDetails {
146146
nameMismatchReason?: string,
147147
extensionRequestDate?: string
148148
}
149+
150+
export interface ValidationStatusError {
151+
error: string;
152+
location: string;
153+
type?: string;
154+
locationType: string;
155+
}
156+
export interface ValidationStatusResponse {
157+
errors: ValidationStatusError[];
158+
isValid?: boolean;
159+
}
160+
export interface ValidationStatusErrorResource {
161+
error: string;
162+
location: string;
163+
location_type: string;
164+
type?: string;
165+
}
166+
export interface ValidationStatusResponseResource {
167+
errors: ValidationStatusErrorResource[];
168+
is_valid?: boolean;
169+
}

0 commit comments

Comments
 (0)