Skip to content

Commit 225e32a

Browse files
Merge pull request #184 from companieshouse/BI-8365-updated-sdk-matched-names
BI-8365: Update SDK to include matched_previous_names
2 parents 3a9b475 + 37dfe34 commit 225e32a

File tree

2 files changed

+27
-2
lines changed

2 files changed

+27
-2
lines changed

src/services/search/dissolved-search/types.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ export interface Items {
1616
kind: string;
1717
ordered_alpha_key_with_id: string;
1818
previous_company_names: PreviousCompanyNames[];
19+
matched_previous_company_name: MatchedPreviousCompanyName;
1920
}
2021

2122
export interface Address {
@@ -30,6 +31,11 @@ export interface PreviousCompanyNames {
3031
effective_from: Date;
3132
name: string;
3233
}
34+
export interface MatchedPreviousCompanyName {
35+
ceased_on: Date;
36+
effective_from: Date;
37+
name: string;
38+
}
3339

3440
export interface TopHit {
3541
registered_office_address: Address;
@@ -41,4 +47,5 @@ export interface TopHit {
4147
kind: string;
4248
ordered_alpha_key_with_id: string;
4349
previous_company_names: PreviousCompanyNames[];
50+
matched_previous_company_name: MatchedPreviousCompanyName;
4451
}

test/services/search/dissolved-search/service.spec.ts

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,13 @@ const mockResponseBody : CompaniesResource = ({
3232
effective_from: (new Date("19910212")),
3333
name: "old name"
3434
}
35-
]
35+
],
36+
matched_previous_company_name:
37+
{
38+
ceased_on: (new Date("19910212")),
39+
effective_from: (new Date("19910212")),
40+
name: "old name"
41+
}
3642
}
3743
],
3844
kind: "kind",
@@ -56,7 +62,13 @@ const mockResponseBody : CompaniesResource = ({
5662
effective_from: (new Date("19910212")),
5763
name: "old name"
5864
}
59-
]
65+
],
66+
matched_previous_company_name:
67+
{
68+
ceased_on: (new Date("19910212")),
69+
effective_from: (new Date("19910212")),
70+
name: "old name"
71+
}
6072
},
6173
hits: 20
6274
});
@@ -120,6 +132,9 @@ describe("create a dissolved search GET", () => {
120132
expect(item.previous_company_names[0].ceased_on).to.equal(mockItem.previous_company_names[0].ceased_on);
121133
expect(item.previous_company_names[0].effective_from).to.equal(mockItem.previous_company_names[0].effective_from);
122134
expect(item.previous_company_names[0].name).to.equal(mockItem.previous_company_names[0].name);
135+
expect(item.matched_previous_company_name.ceased_on).to.equal(mockItem.matched_previous_company_name.ceased_on);
136+
expect(item.matched_previous_company_name.effective_from).to.equal(mockItem.matched_previous_company_name.effective_from);
137+
expect(item.matched_previous_company_name.name).to.equal(mockItem.matched_previous_company_name.name);
123138
expect(data.resource.kind).to.equal(mockResponseBody.kind);
124139
expect(data.resource.top_hit.registered_office_address.address_line_1).to.equal(mockResponseBody.top_hit.registered_office_address.address_line_1);
125140
expect(data.resource.top_hit.registered_office_address.address_line_2).to.equal(mockResponseBody.top_hit.registered_office_address.address_line_2);
@@ -134,6 +149,9 @@ describe("create a dissolved search GET", () => {
134149
expect(data.resource.top_hit.previous_company_names[0].ceased_on).to.equal(mockResponseBody.top_hit.previous_company_names[0].ceased_on);
135150
expect(data.resource.top_hit.previous_company_names[0].effective_from).to.equal(mockResponseBody.top_hit.previous_company_names[0].effective_from);
136151
expect(data.resource.top_hit.previous_company_names[0].name).to.equal(mockResponseBody.top_hit.previous_company_names[0].name);
152+
expect(data.resource.top_hit.matched_previous_company_name.ceased_on).to.equal(mockResponseBody.top_hit.matched_previous_company_name.ceased_on);
153+
expect(data.resource.top_hit.matched_previous_company_name.effective_from).to.equal(mockResponseBody.top_hit.matched_previous_company_name.effective_from);
154+
expect(data.resource.top_hit.matched_previous_company_name.name).to.equal(mockResponseBody.top_hit.matched_previous_company_name.name);
137155
expect(data.resource.hits).to.equal(mockResponseBody.hits);
138156
});
139157
});

0 commit comments

Comments
 (0)