Merge pull request #449 from companieshouse/feature/roe-1201-update-oe-servce-method

Feature/roe 1201 update oe servce method

Author: mouhajer-ch

src/services/overseas-entities/service.ts

@@ -10,7 +10,7 @@ export default class OverseasEntityService {
         const URL = `/transactions/${transactionId}/overseas-entity`;
         const response: HttpResponse = await this.client.httpPost(URL, mapOverseasEntity(body));
 
-        if (response.error && response.status !== 400) {
+        if (response.error) {
             return {
                 httpStatusCode: response.status,
                 errors: [response.error]

test/services/overseas-entities/overseas.entities.mock.ts

@@ -435,9 +435,11 @@ export const requestClient = new RequestClient({ baseUrl: "URL_NOT_USED", oauthT
 
 export const TRANSACTION_ID = "12345";
 export const UNAUTHORISED = "Unauthorised";
+export const BAD_REQUEST = "Bad Request";
 
 export const mockOverseasEntityCreatedResource: OverseasEntityCreated = { id: "00112233" };
 export const mockPostOverseasEntityResponse = {
     201: { status: 201, body: mockOverseasEntityCreatedResource },
+    400: { status: 400, error: BAD_REQUEST },
     401: { status: 401, error: UNAUTHORISED }
 };

test/services/overseas-entities/overseas.entities.spec.ts

@@ -6,7 +6,6 @@ import * as mockValues from "./overseas.entities.mock";
 import {
     BeneficialOwnersStatementType,
     OverseasEntityCreated,
-    OverseasEntityDueDiligenceResource,
     OverseasEntityService
 } from "../../../src/services/overseas-entities";
 import Resource, { ApiErrorResponse } from "../../../src/services/resource";
@@ -45,6 +44,16 @@ describe("OverseasEntityService Tests suite", () => {
         expect(data.httpStatusCode).to.equal(401);
         expect(data.errors?.[0]).to.equal(mockValues.UNAUTHORISED);
     });
+
+    it("should return error 400 (Bad Request) for postOverseasEntity method", async () => {
+        sinon.stub(mockValues.requestClient, "httpPost").resolves(mockValues.mockPostOverseasEntityResponse[400]);
+
+        const oeService = new OverseasEntityService(mockValues.requestClient);
+        const data = await oeService.postOverseasEntity(mockValues.TRANSACTION_ID, {}) as ApiErrorResponse;
+
+        expect(data.httpStatusCode).to.equal(400);
+        expect(data.errors?.[0]).to.equal(mockValues.BAD_REQUEST);
+    });
 });
 
 describe("Mapping OverseasEntity Tests suite", () => {