Merge pull request #793 from companieshouse/IDVA52197

IDVA5-2197 Register an ACSP - Allow Previously Closed/ Ceased ACSPs to Access Registration Service -mapping the filing details to camel case from snake case

Author: rdas-ch

src/services/transaction/service.ts

@@ -201,7 +201,22 @@ export default class TransactionService {
                 id: i.id,
                 updatedAt: i.updated_at,
                 status: i.status,
-                filings: i.filings,
+                filings: i.filings
+                    ? (() => {
+                        const result = {};
+                        for (const key in i.filings) {
+                            if (Object.prototype.hasOwnProperty.call(i.filings, key)) {
+                                const filing = i.filings[key];
+                                result[key] = {
+                                    status: filing.status,
+                                    companyNumber: filing.company_number,
+                                    type: filing.type
+                                };
+                            }
+                        }
+                        return result;
+                    })()
+                    : undefined,
                 resumeJourneyUri: i.resume_journey_uri
             })) : []
         };

test/services/transaction/service.spec.ts

@@ -157,37 +157,73 @@ describe("transaction", () => {
         expect(castedData.errors?.[0]).to.equal("Unprocessable Entity");
     });
 
-    it("get transaction list for resource kind returns success response ", async () => {
-        const itemsArray: TransactionData[] = ([
-            {
-                id: "123",
-                status: "closed",
-                filings: {
-                    testFiling: {
-                        status: "accepted",
-                        companyNumber: "AP000042",
-                        type: "acsp"
-                    } as Filing
+    it("getTransactionsForResourceKind returns a transaction list with mapped filings object", async () => {
+        const mockResponseBody = {
+            items: [
+                {
+                    id: "txn1",
+                    updated_at: "2024-06-25T12:00:00Z",
+                    status: "closed",
+                    filings: {
+                        testFiling: {
+                            status: "accepted",
+                            company_number: "AP000042",
+                            type: "acsp"
+                        },
+                        anotherFiling: {
+                            status: "pending",
+                            company_number: "AP000043",
+                            type: "bcsp"
+                        }
+                    },
+                    resume_journey_uri: "/resume/txn1"
                 }
-            }
-        ]);
-
-        const transactionList: TransactionList = ({
-            items: itemsArray
-        });
+            ]
+        };
 
         const mockGetResponse = {
             status: 200,
-            body: transactionList
+            body: mockResponseBody
         };
 
-        const mockRequest = sinon.stub(requestClient, "httpGet").resolves(mockGetResponse);
-        const transaction : TransactionService = new TransactionService(requestClient);
-        const data = await transaction.getTransactionsForResourceKind({} as string);
+        sinon.stub(requestClient, "httpGet").resolves(mockGetResponse);
+        const transaction: TransactionService = new TransactionService(requestClient);
+        const data = await transaction.getTransactionsForResourceKind("req-123", "some-kind");
+
         expect(data.httpStatusCode).to.equal(200);
         const castedData: Resource<TransactionList> = data as Resource<TransactionList>;
-        expect(castedData.resource?.items[0].id).to.equal(transactionList.items[0].id);
-        expect(castedData.resource?.items[0].status).to.equal(transactionList.items[0].status);
-        expect(castedData.resource?.items[0].filings).to.equal(transactionList.items[0].filings);
+        expect(castedData.resource?.items).to.have.lengthOf(1);
+        const item = castedData.resource?.items[0];
+        expect(item?.id).to.equal("txn1");
+        expect(item?.updatedAt).to.equal("2024-06-25T12:00:00Z");
+        expect(item?.status).to.equal("closed");
+        expect(item?.resumeJourneyUri).to.equal("/resume/txn1");
+        expect(item?.filings).to.have.property("testFiling");
+        expect(item?.filings).to.have.property("anotherFiling");
+        expect(item?.filings.testFiling).to.deep.equal({
+            status: "accepted",
+            companyNumber: "AP000042",
+            type: "acsp"
+        });
+        expect(item?.filings.anotherFiling).to.deep.equal({
+            status: "pending",
+            companyNumber: "AP000043",
+            type: "bcsp"
+        });
+    });
+
+    it("getTransactionsForResourceKind returns error response on failure", async () => {
+        const mockGetResponse = {
+            status: 500,
+            error: "Internal Server Error"
+        };
+
+        sinon.stub(requestClient, "httpGet").resolves(mockGetResponse);
+        const transaction: TransactionService = new TransactionService(requestClient);
+        const data = await transaction.getTransactionsForResourceKind("req-123", "some-kind");
+
+        expect(data.httpStatusCode).to.equal(500);
+        const castedData: ApiErrorResponse = data as ApiErrorResponse;
+        expect(castedData.errors[0]).to.equal("Internal Server Error");
     });
 });