Skip to content

Commit 5981fdf

Browse files
authored
Merge pull request #812 from companieshouse/feat/cc-2938/update-to-v24
feat/cc-2938: upgrade to v24
2 parents 3a34ce4 + a5a263a commit 5981fdf

File tree

4 files changed

+150
-50
lines changed

4 files changed

+150
-50
lines changed

README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@ This SDK abstract the calls to our public APIs.
44

55
Intended for use when making cross-web-service calls, supporting ERIC and the propagation of authentication details through to other services.
66

7+
## Compatible Node versions
8+
9+
This package has been upgraded to be compatible with Node v24. Presently, it's backward compatible with v20 and v18 but compatibility is primarily required for v24 as all CH Node services are in the process of being upgraded to v24.
10+
711
## Quick start
812

913
Use NPM to install the SDK in your project;

package-lock.json

Lines changed: 144 additions & 48 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/http/request-client.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import chai from "chai";
22
import sinon from "sinon";
33

44
import { RequestClient } from "../../src/http";
5-
import nock = require("nock");
5+
import nock from "nock";
66
const expect = chai.expect;
77

88
describe("request-client", () => {

test/services/certificates/service.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import {
1212
} from "../../../src/services/order/certificates";
1313
import { ApiErrorResponse, ApiResponse } from "../../../src/services/resource";
1414
import { Failure, Success } from "../../../src/services/result";
15-
import nock = require("nock");
15+
import nock from "nock";
1616

1717
const expect = chai.expect;
1818

0 commit comments

Comments
 (0)