Skip to content

Commit 6aeef4a

Browse files
authored
Merge pull request #783 from companieshouse/feature/lp-844-gp-completed
lp-844 : limited partnership - add field completed to partner
2 parents 88b6ff0 + 37e934f commit 6aeef4a

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

src/services/limited-partnerships/types.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,9 @@ export interface LimitedPartnership {
2929
lawful_purpose_statement_checked?: boolean;
3030
};
3131
}
32+
3233
type Partner = {
34+
completed?: boolean;
3335
date_effective_from?: string;
3436
date_of_birth?: string;
3537
etag?: string;
@@ -49,14 +51,14 @@ type Partner = {
4951
resignation_date?: string;
5052
surname?: string;
5153
usual_residential_address?: Address;
52-
}
54+
};
5355

5456
export interface LimitedPartner {
5557
id?: string;
5658
data?: Partner & {
57-
contribution_currency_type?: string,
58-
contribution_currency_value?: string,
59-
contribution_non_monetary_value?: string
59+
contribution_currency_type?: string;
60+
contribution_currency_value?: string;
61+
contribution_non_monetary_value?: string;
6062
};
6163
}
6264

test/services/limited-partnerships/limited.partnerships.mock.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ export const LIMITED_PARTNERSHIP_OBJECT_MOCK: LimitedPartnership = {
5252
export const GENERAL_PARTNER_OBJECT_MOCK: GeneralPartner = {
5353
id: "123456",
5454
data: {
55+
completed: true,
5556
date_effective_from: "2005-02-04",
5657
date_of_birth: "2000-05-01",
5758
etag: "",
@@ -103,6 +104,7 @@ export const GENERAL_PARTNER_OBJECT_MOCK: GeneralPartner = {
103104
export const LIMITED_PARTNER_OBJECT_MOCK: LimitedPartner = {
104105
id: "123456",
105106
data: {
107+
completed: true,
106108
contribution_currency_type: "GBP",
107109
contribution_currency_value: "1000",
108110
contribution_non_monetary_value: "car",

0 commit comments

Comments
 (0)