Refactor validation response structures (#845)

Author: jmccoubrey-ch

src/services/psc-extensions-link/types.ts

@@ -149,13 +149,11 @@ export interface ExtensionDetails {
 }
 
 export interface ValidationStatusError {
-    error: string;
-    location: string;
-    type?: string;
-    locationType: string;
+    field: string;
+    message: string;
 }
 export interface ValidationStatusResponse {
-    errors: ValidationStatusError[];
+    validationStatusError: ValidationStatusError[];
     valid: boolean;
 }
 export interface ValidationStatusErrorResource {

test/services/psc-extensions-link/service.mock.ts

@@ -48,34 +48,30 @@ export const PSC_EXTENSION: PscExtension = {
 
 const VALIDATION_STATUS_RESPONSE_RESOURCE = {
     valid: true,
-    errors: []
+    validation_status_error: []
 };
 
 export const VALIDATION_STATUS_RESPONSE: ValidationStatusResponse = {
     valid: true,
-    errors: []
+    validationStatusError: []
 };
 
 const VALIDATION_STATUS_RESPONSE_INVALID_RESOURCE = {
     valid: false,
-    errors: [
+    validation_status_error: [
         {
-            error: "PSC has exceeded maximum number of extension requests",
-            location: "$.",
-            location_type: "json-path",
-            type: "ch:validation"
+            message: "PSC has exceeded maximum number of extension requests",
+            field: "$."
         }
     ]
 };
 
 export const VALIDATION_STATUS_RESPONSE_INVALID: ValidationStatusResponse = {
     valid: false,
-    errors: [
+    validationStatusError: [
         {
-            error: "PSC has exceeded maximum number of extension requests",
-            location: "$.",
-            locationType: "json-path",
-            type: "ch:validation"
+            message: "PSC has exceeded maximum number of extension requests",
+            field: "$."
         }
     ]
 };

test/services/psc-extensions-link/service.spec.ts

@@ -156,7 +156,7 @@ describe("PSC Extensions Service", () => {
 
             expect(response.httpStatusCode).to.equal(StatusCodes.OK);
             expect(response.resource!.valid).to.be.true;
-            expect(response.resource!.errors).to.be.empty;
+            expect(response.resource!.validationStatusError).to.be.empty;
         });
 
         it("should return status 200 OK and validation response when extension is invalid", async () => {
@@ -167,8 +167,8 @@ describe("PSC Extensions Service", () => {
 
             expect(response.httpStatusCode).to.equal(StatusCodes.OK);
             expect(response.resource!.valid).to.be.false;
-            expect(response.resource!.errors).to.have.length(1);
-            expect(response.resource!.errors[0].error).to.equal("PSC has exceeded maximum number of extension requests");
+            expect(response.resource!.validationStatusError).to.have.length(1);
+            expect(response.resource!.validationStatusError[0].message).to.equal("PSC has exceeded maximum number of extension requests");
         });
 
         it("should return status 400 Bad Request when parameters are invalid", async () => {