Merge pull request #263 from companieshouse/NCS-619-amend-psc-details

NCS-619 Add the register location field to the psc model

Author: kheseyongya

src/services/confirmation-statement/service.ts

@@ -343,6 +343,7 @@ export default class {
                 serviceAddressCountryName: pscResource.service_address_country_name,
                 serviceAddressHouseNameNumber: pscResource.service_address_house_name_number,
                 companyName: pscResource.company_name,
+                registerLocation: pscResource.register_location,
                 registrationNumber: pscResource.registration_number,
                 lawGoverned: pscResource.law_governed,
                 legalForm: pscResource.legal_form,
@@ -386,6 +387,7 @@ export default class {
                 service_address_region: psc.serviceAddressRegion,
                 service_address_house_name_number: psc.serviceAddressHouseNameNumber,
                 company_name: psc.companyName,
+                register_location: psc.registerLocation,
                 registration_number: psc.registrationNumber,
                 law_governed: psc.lawGoverned,
                 legal_form: psc.legalForm,

src/services/confirmation-statement/types.ts

@@ -203,6 +203,7 @@ export interface PersonOfSignificantControl {
     serviceAddressArea?: string;
     serviceAddressHouseNameNumber?: string;
     companyName?: string;
+    registerLocation?: string;
     registrationNumber?: string;
     lawGoverned?: string;
     legalForm?: string;
@@ -252,6 +253,7 @@ export interface PersonOfSignificantControlResource {
     service_address_area?: string;
     service_address_house_name_number?: string;
     company_name?: string;
+    register_location?: string;
     registration_number?: string;
     law_governed?: string;
     legal_form?: string;

test/services/confirmation-statement/confirmation.statement.mock.ts

@@ -127,6 +127,7 @@ export const mockPersonsWithSignificantControlList: PersonOfSignificantControlRe
         service_address_area: "area",
         service_address_house_name_number: "house name number",
         company_name: "Company1",
+        register_location: "ENGLAND",
         registration_number: "67890",
         law_governed: "ENGLISH",
         legal_form: "LIMITED",
@@ -152,6 +153,7 @@ export const mockPersonsWithSignificantControlList: PersonOfSignificantControlRe
         service_address_post_code: "SW1 3ZZ",
         service_address_post_town: "Somewhere",
         company_name: "Company2",
+        register_location: "ENGLAND",
         registration_number: "123456",
         law_governed: "ENGLISH",
         legal_form: "LIMITED",
@@ -172,6 +174,7 @@ export const mockPscNoNameNoAddress: PersonOfSignificantControlResource[] = [
         service_address_post_code: "NO1 0AA",
         service_address_post_town: "Nowhere",
         company_name: "Company1",
+        register_location: "ENGLAND",
         registration_number: "67890",
         law_governed: "ENGLISH",
         legal_form: "LIMITED",

test/services/confirmation-statement/confirmation.statement.spec.ts

@@ -281,6 +281,7 @@ describe("persons with significant control GET", () => {
         expect(data.resource[0].serviceAddressPoBox).to.equal("po box");
         expect(data.resource[0].serviceAddressRegion).to.equal("region");
         expect(data.resource[0].serviceAddressHouseNameNumber).to.equal("house name number");
+        expect(data.resource[0].registerLocation).to.equal("ENGLAND");
     });
 
     it("should not map missing address or names", async () => {