SIV-478 The function for creating an association and invitation split into two independent functions

Author: mmodzelewski-ch

src/services/associations/service.ts

@@ -116,21 +116,34 @@ export default class AssociationsService {
     }
 
     /**
-     * Creates a new association for a user in session.
-     * @param companyNumber - a company number of the company with which a new association for the user will be created.
-     * @param inviteeEmailAddress - an email address of the user invited to have an association with a company.
-     * @returns a promise that resolves to the HTTP response from the server that includes the new association's link (it contains the association identifier) or errors object.
+     * Creates a new association for a user with provided userId.
+     * @param companyNumber - The company number for the new association.
+     * @param userId - The user's unique identifier.
+     * @returns A promise resolving to the new association's link or errors object.
      */
     public async createAssociation (
         companyNumber: string,
-        inviteeEmailAddress?: string
+        userId: string
     ): Promise<Resource<NewAssociationResponse | Errors>> {
-        const url = inviteeEmailAddress ? "/associations/invitations" : "/associations";
-        const body = inviteeEmailAddress
-            ? { company_number: companyNumber, invitee_email_id: inviteeEmailAddress }
-            : { company_number: companyNumber };
+        const url = "/associations";
+        const body = { company_number: companyNumber, user_id: userId };
         const response = await this.client.httpPost(url, body);
+        return this.getResource(response) as Resource<NewAssociationResponse | Errors>;
+    }
 
+    /**
+     * Invites a user with the provided email address to a company.
+     * @param companyNumber - The company number.
+     * @param inviteeEmailAddress - The email address of the user to invite.
+     * @returns A promise resolving to the new association's link or errors object.
+     */
+    public async inviteUser (
+        companyNumber: string,
+        inviteeEmailAddress: string
+    ): Promise<Resource<NewAssociationResponse | Errors>> {
+        const url = "/associations/invitations";
+        const body = { company_number: companyNumber, invitee_email_id: inviteeEmailAddress };
+        const response = await this.client.httpPost(url, body);
         return this.getResource(response) as Resource<NewAssociationResponse | Errors>;
     }
 

test/services/associations/service.spec.ts

@@ -432,7 +432,7 @@ describe("AssociationsService", () => {
 
     describe("createAssociation", () => {
         let associationsService: AssociationsService;
-        const inviteeEmailAddress = "[email protected]";
+        const userId = "1234567890";
 
         beforeEach(() => {
             sinon.reset();
@@ -442,17 +442,7 @@ describe("AssociationsService", () => {
 
         it("should return 201 response if a new association created", async () => {
             sinon.stub(requestClient, "httpPost").resolves(mockPostResponse[201]);
-            await associationsService.createAssociation(companyNumber).then((data) => {
-                expect(data.httpStatusCode).to.equal(201);
-                const castedData: Resource<NewAssociationResponse> = data as Resource<NewAssociationResponse>;
-                expect(castedData).to.exist;
-                expect(castedData.resource?.associationLink).to.equal("/associations/123456");
-            });
-        });
-
-        it("should return 201 response if a new association created for invited user", async () => {
-            sinon.stub(requestClient, "httpPost").resolves(mockPostResponse[201]);
-            await associationsService.createAssociation(companyNumber, inviteeEmailAddress).then((data) => {
+            await associationsService.createAssociation(companyNumber, userId).then((data) => {
                 expect(data.httpStatusCode).to.equal(201);
                 const castedData: Resource<NewAssociationResponse> = data as Resource<NewAssociationResponse>;
                 expect(castedData).to.exist;
@@ -462,62 +452,90 @@ describe("AssociationsService", () => {
 
         it("should return 400 response", async () => {
             sinon.stub(requestClient, "httpPost").resolves(mockPostResponse[400]);
-            await associationsService.createAssociation(companyNumber)
-                .then((data) => {
-                    expect(data.httpStatusCode).to.equal(400);
-                });
-        });
-
-        it("should return 400 response for invited user", async () => {
-            sinon.stub(requestClient, "httpPost").resolves(mockPostResponse[400]);
-            await associationsService.createAssociation(companyNumber, inviteeEmailAddress)
+            await associationsService.createAssociation(companyNumber, userId)
                 .then((data) => {
                     expect(data.httpStatusCode).to.equal(400);
                 });
         });
 
         it("should return 401 response", async () => {
             sinon.stub(requestClient, "httpPost").resolves(mockPostResponse[401]);
-            await associationsService.createAssociation(companyNumber)
+            await associationsService.createAssociation(companyNumber, userId)
                 .then((data) => {
                     expect(data.httpStatusCode).to.equal(401);
                 });
         });
 
         it("should return 401 response for invited user", async () => {
             sinon.stub(requestClient, "httpPost").resolves(mockPostResponse[401]);
-            await associationsService.createAssociation(companyNumber, inviteeEmailAddress).then((data) => {
+            await associationsService.createAssociation(companyNumber, userId).then((data) => {
                 expect(data.httpStatusCode).to.equal(401);
             });
         });
 
         it("should return 403 response", async () => {
             sinon.stub(requestClient, "httpPost").resolves(mockPostResponse[403]);
-            await associationsService.createAssociation(companyNumber)
+            await associationsService.createAssociation(companyNumber, userId)
                 .then((data) => {
                     expect(data.httpStatusCode).to.equal(403);
                 });
         });
 
-        it("should return 403 response for invited user", async () => {
-            sinon.stub(requestClient, "httpPost").resolves(mockPostResponse[403]);
+        it("should return 500 response", async () => {
+            sinon.stub(requestClient, "httpPost").resolves(mockPostResponse[500]);
+            await associationsService.createAssociation(companyNumber, userId)
+                .then((data) => {
+                    expect(data.httpStatusCode).to.equal(500);
+                });
+        });
+    });
+
+    describe("inviteUser", () => {
+        let associationsService: AssociationsService;
+        const inviteeEmailAddress = "[email protected]";
+
+        beforeEach(() => {
+            sinon.reset();
+            sinon.restore();
+            associationsService = new AssociationsService(requestClient);
+        });
+
+        it("should return 201 response if a new association created for invited user", async () => {
+            sinon.stub(requestClient, "httpPost").resolves(mockPostResponse[201]);
+            await associationsService.inviteUser(companyNumber, inviteeEmailAddress).then((data) => {
+                expect(data.httpStatusCode).to.equal(201);
+                const castedData: Resource<NewAssociationResponse> = data as Resource<NewAssociationResponse>;
+                expect(castedData).to.exist;
+                expect(castedData.resource?.associationLink).to.equal("/associations/123456");
+            });
+        });
+
+        it("should return 400 response for invited user", async () => {
+            sinon.stub(requestClient, "httpPost").resolves(mockPostResponse[400]);
             await associationsService.createAssociation(companyNumber, inviteeEmailAddress)
                 .then((data) => {
-                    expect(data.httpStatusCode).to.equal(403);
+                    expect(data.httpStatusCode).to.equal(400);
                 });
         });
 
-        it("should return 500 response", async () => {
-            sinon.stub(requestClient, "httpPost").resolves(mockPostResponse[500]);
-            await associationsService.createAssociation(companyNumber)
+        it("should return 401 response for invited user", async () => {
+            sinon.stub(requestClient, "httpPost").resolves(mockPostResponse[401]);
+            await associationsService.inviteUser(companyNumber, inviteeEmailAddress).then((data) => {
+                expect(data.httpStatusCode).to.equal(401);
+            });
+        });
+
+        it("should return 403 response for invited user", async () => {
+            sinon.stub(requestClient, "httpPost").resolves(mockPostResponse[403]);
+            await associationsService.inviteUser(companyNumber, inviteeEmailAddress)
                 .then((data) => {
-                    expect(data.httpStatusCode).to.equal(500);
+                    expect(data.httpStatusCode).to.equal(403);
                 });
         });
 
         it("should return 500 response for invited user", async () => {
             sinon.stub(requestClient, "httpPost").resolves(mockPostResponse[500]);
-            await associationsService.createAssociation(companyNumber, inviteeEmailAddress)
+            await associationsService.inviteUser(companyNumber, inviteeEmailAddress)
                 .then((data) => {
                     expect(data.httpStatusCode).to.equal(500);
                 });