Merge pull request #787 from companieshouse/lp-857-add-filing-mode-to-transaction

Lp 857 add filing mode to transaction

Author: markpit

src/services/transaction/service.ts

@@ -119,6 +119,7 @@ export default class TransactionService {
             links: body.links,
             reference: body.reference,
             status: body.status,
+            filingMode: body.filing_mode,
             kind: body.kind,
             companyName: body.company_name,
             companyNumber: body.company_number,

src/services/transaction/types.ts

@@ -7,6 +7,7 @@ export interface TransactionResource {
     links?: {self: string},
     reference: string,
     status?: string,
+    filing_mode?: string,
     kind?: string,
     company_name?: string,
     company_number: string,
@@ -35,6 +36,7 @@ export interface Transaction {
     links?: {self: string},
     reference: string,
     status?: string,
+    filingMode?: string,
     kind?: string,
     companyName?: string,
     companyNumber?: string,

test/services/transaction/service.spec.ts

@@ -34,7 +34,7 @@ describe("transaction", () => {
 
         expect(data.httpStatusCode).to.equal(401);
         const castedData: ApiErrorResponse = data;
-        expect(castedData.errors[0]).to.equal("An error occurred");
+        expect(castedData.errors?.[0]).to.equal("An error occurred");
     });
 
     it("post maps the company field data items correctly", async () => {
@@ -69,11 +69,12 @@ describe("transaction", () => {
 
         expect(data.httpStatusCode).to.equal(200);
         const castedData: Resource<Transaction> = data as Resource<Transaction>;
-        expect(castedData.resource.companyName).to.equal(mockResponseBody.company_name);
-        expect(castedData.resource.companyNumber).to.equal(mockResponseBody.company_number);
-        expect(castedData.resource.links.self).to.equal(mockResponseBody.links.self);
-        expect(castedData.resource.reference).to.equal(mockResponseBody.reference);
-        expect(castedData.resource.description).to.equal(mockResponseBody.description);
+        const resource = castedData.resource;
+        expect(resource?.companyName).to.equal(mockResponseBody.company_name);
+        expect(resource?.companyNumber).to.equal(mockResponseBody.company_number);
+        expect(resource?.links?.self).to.equal(mockResponseBody.links?.self);
+        expect(resource?.reference).to.equal(mockResponseBody.reference);
+        expect(resource?.description).to.equal(mockResponseBody.description);
     });
 
     it("get returns an error response on failure", async () => {
@@ -88,14 +89,15 @@ describe("transaction", () => {
 
         expect(data.httpStatusCode).to.equal(401);
         const castedData: ApiErrorResponse = data;
-        expect(castedData.errors[0]).to.equal("An error occurred");
+        expect(castedData.errors?.[0]).to.equal("An error occurred");
     });
 
     it("get maps the company field data items correctly", async () => {
         const mockResponseBody : TransactionResource = ({
             id: "12345678",
             company_name: "HELLO LTD",
             company_number: "88",
+            filing_mode: "default",
             links: {
                 self: "/self"
             },
@@ -114,11 +116,13 @@ describe("transaction", () => {
 
         expect(data.httpStatusCode).to.equal(200);
         const castedData: Resource<Transaction> = data as Resource<Transaction>;
-        expect(castedData.resource.companyName).to.equal(mockResponseBody.company_name);
-        expect(castedData.resource.companyNumber).to.equal(mockResponseBody.company_number);
-        expect(castedData.resource.links.self).to.equal(mockResponseBody.links.self);
-        expect(castedData.resource.reference).to.equal(mockResponseBody.reference);
-        expect(castedData.resource.description).to.equal(mockResponseBody.description);
+        const resource = castedData.resource;
+        expect(resource?.companyName).to.equal(mockResponseBody.company_name);
+        expect(resource?.companyNumber).to.equal(mockResponseBody.company_number);
+        expect(resource?.filingMode).to.equal(mockResponseBody.filing_mode);
+        expect(resource?.links?.self).to.equal(mockResponseBody.links?.self);
+        expect(resource?.reference).to.equal(mockResponseBody.reference);
+        expect(resource?.description).to.equal(mockResponseBody.description);
     });
 
     it("put returns successful response", async () => {
@@ -135,7 +139,7 @@ describe("transaction", () => {
 
         expect(data.httpStatusCode).to.equal(202);
         const castedData: ApiResponse<Transaction> = data as ApiResponse<Transaction>;
-        expect(castedData.headers["X-Payment-Required"]).to.equal("http://link-to-payment");
+        expect(castedData.headers?.["X-Payment-Required"]).to.equal("http://link-to-payment");
     });
 
     it("put returns an error response on failure", async () => {
@@ -150,7 +154,7 @@ describe("transaction", () => {
 
         expect(data.httpStatusCode).to.equal(422);
         const castedData: ApiErrorResponse = data;
-        expect(castedData.errors[0]).to.equal("Unprocessable Entity");
+        expect(castedData.errors?.[0]).to.equal("Unprocessable Entity");
     });
 
     it("get transaction list for resource kind returns success response ", async () => {