Merge pull request #233 from companieshouse/feature/BI-8941_add_missing_field

BI-8941 Add missing field to certificates

Author: phudson-ch

src/services/order/certificates/mapping.ts

@@ -67,6 +67,7 @@ export default class CertificateMapping {
                 general_partner_details: generalPartnerDetails,
                 include_company_objects_information: itemOptions.includeCompanyObjectsInformation,
                 include_email_copy: itemOptions.includeEmailCopy,
+                include_general_nature_of_business_information: itemOptions.includeGeneralNatureOfBusinessInformation,
                 include_good_standing_information: itemOptions.includeGoodStandingInformation,
                 limited_partner_details: limitedPartnerDetails,
                 member_details: ordinaryMemberDetails,
@@ -134,6 +135,7 @@ export default class CertificateMapping {
                 generalPartnerDetails,
                 includeCompanyObjectsInformation: io.include_company_objects_information,
                 includeEmailCopy: io.include_email_copy,
+                includeGeneralNatureOfBusinessInformation: io.include_general_nature_of_business_information,
                 includeGoodStandingInformation: io.include_good_standing_information,
                 limitedPartnerDetails,
                 memberDetails: ordinaryMemberDetails,

src/services/order/certificates/types.ts

@@ -41,6 +41,7 @@ export interface ItemOptionsResource {
     general_partner_details: GeneralPartnerDetailsResource;
     include_company_objects_information: boolean;
     include_email_copy: boolean;
+    include_general_nature_of_business_information: boolean;
     include_good_standing_information: boolean;
     limited_partner_details: LimitedPartnerDetailsResource;
     member_details: OrdinaryMemberDetailsResource;
@@ -142,6 +143,7 @@ export interface ItemOptions {
     generalPartnerDetails?: GeneralPartnerDetails;
     includeCompanyObjectsInformation: boolean;
     includeEmailCopy: boolean;
+    includeGeneralNatureOfBusinessInformation: boolean;
     includeGoodStandingInformation: boolean;
     limitedPartnerDetails?: LimitedPartnerDetails;
     memberDetails?: OrdinaryMemberDetails;
@@ -228,6 +230,7 @@ export interface ItemOptionsRequest {
     generalPartnerDetails?: GeneralPartnerDetailsRequest;
     includeCompanyObjectsInformation?: boolean | null;
     includeEmailCopy?: boolean;
+    includeGeneralNatureOfBusinessInformation?: boolean | null;
     includeGoodStandingInformation?: boolean | null;
     limitedPartnerDetails?: LimitedPartnerDetailsRequest;
     memberDetails?: OrdinaryMemberDetailsRequest;

src/services/order/order/mapping.ts

@@ -134,6 +134,7 @@ export default class OrderMapping {
                 deliveryTimescale: itemResource.delivery_timescale,
                 deliveryMethod: itemResource.delivery_method,
                 designatedMemberDetails: designatedMemberDetails,
+                includeGeneralNatureOfBusinessInformation: itemResource.include_general_nature_of_business_information,
                 includeGoodStandingInformation: itemResource.include_good_standing_information,
                 includeCompanyObjectsInformation: itemResource.include_company_objects_information,
                 generalPartnerDetails: generalPartnerDetails,

src/services/order/order/types.ts

@@ -76,6 +76,7 @@ export interface CertificateItemOptions {
     generalPartnerDetails: {
         includeBasicInformation?: boolean;
     };
+    includeGeneralNatureOfBusinessInformation?: boolean;
     includeGoodStandingInformation?: boolean;
     includeCompanyObjectsInformation?: boolean;
     limitedPartnerDetails: {
@@ -216,6 +217,7 @@ export interface CertificateItemOptionsResource {
         include_country_of_residence?: boolean;
         include_dob_type?: string;
     };
+    include_general_nature_of_business_information?: boolean;
     include_good_standing_information?: boolean;
     include_company_objects_information?: boolean;
     general_partner_details: {

test/services/certificates/service.spec.ts

@@ -56,6 +56,7 @@ const mockResponseBody : CertificateItemResource = ({
         },
         include_company_objects_information: true,
         include_email_copy: true,
+        include_general_nature_of_business_information: true,
         include_good_standing_information: true,
         limited_partner_details: {
             include_basic_information: true
@@ -126,6 +127,7 @@ const mockResponseBodyMissingFields : CertificateItemResource = ({
         general_partner_details: undefined,
         include_company_objects_information: true,
         include_email_copy: true,
+        include_general_nature_of_business_information: true,
         include_good_standing_information: true,
         limited_partner_details: undefined,
         member_details: undefined,
@@ -236,6 +238,7 @@ describe("order a certificate GET", () => {
         expect(resourceItemOptions.forename).to.equal(mockItemOptions.forename);
         expect(resourceItemOptions.includeCompanyObjectsInformation).to.equal(mockItemOptions.include_company_objects_information);
         expect(resourceItemOptions.includeEmailCopy).to.equal(mockItemOptions.include_email_copy);
+        expect(resourceItemOptions.includeGeneralNatureOfBusinessInformation).to.equal(mockItemOptions.include_general_nature_of_business_information);
         expect(resourceItemOptions.includeGoodStandingInformation).to.equal(mockItemOptions.include_good_standing_information);
         expect(resourceLimitedPartnerDetails.includeBasicInformation).to.equal(mockLimitedPartnerDetails.include_basic_information);
         expect(resourceMemberDetails.includeAddress).to.equal(mockMemberDetails.include_address);
@@ -317,6 +320,7 @@ describe("order a certificate GET", () => {
         expect(resourceItemOptions.forename).to.equal(mockItemOptions.forename);
         expect(resourceItemOptions.includeCompanyObjectsInformation).to.equal(mockItemOptions.include_company_objects_information);
         expect(resourceItemOptions.includeEmailCopy).to.equal(mockItemOptions.include_email_copy);
+        expect(resourceItemOptions.includeGeneralNatureOfBusinessInformation).to.equal(mockItemOptions.include_general_nature_of_business_information);
         expect(resourceItemOptions.includeGoodStandingInformation).to.equal(mockItemOptions.include_good_standing_information);
         expect(resourceLimitedPartnerDetails).to.be.undefined;
         expect(resourceMemberDetails).to.be.undefined;
@@ -372,6 +376,7 @@ describe("create a certificate POST", () => {
             },
             includeCompanyObjectsInformation: true,
             includeEmailCopy: true,
+            includeGeneralNatureOfBusinessInformation: true,
             includeGoodStandingInformation: true,
             limitedPartnerDetails: {
                 includeBasicInformation: true
@@ -467,6 +472,7 @@ describe("create a certificate POST", () => {
         expect(io.generalPartnerDetails.includeBasicInformation).to.equal(mockIo.general_partner_details.include_basic_information);
         expect(io.includeCompanyObjectsInformation).to.equal(mockIo.include_company_objects_information);
         expect(io.includeEmailCopy).to.equal(mockIo.include_email_copy);
+        expect(io.includeGeneralNatureOfBusinessInformation).to.equal(mockIo.include_general_nature_of_business_information);
         expect(io.includeGoodStandingInformation).to.equal(mockIo.include_good_standing_information);
         expect(io.limitedPartnerDetails.includeBasicInformation).to.equal(mockIo.limited_partner_details.include_basic_information);
         expect(io.memberDetails.includeAddress).to.equal(mockIo.member_details.include_address);
@@ -513,6 +519,7 @@ describe("create a certificate POST", () => {
         expect(io.forename).to.equal(mockIo.forename);
         expect(io.includeCompanyObjectsInformation).to.equal(mockIo.include_company_objects_information);
         expect(io.includeEmailCopy).to.equal(mockIo.include_email_copy);
+        expect(io.includeGeneralNatureOfBusinessInformation).to.equal(mockIo.include_general_nature_of_business_information);
         expect(io.includeGoodStandingInformation).to.equal(mockIo.include_good_standing_information);
         expect(io.registeredOfficeAddressDetails).to.be.undefined;
         expect(io.secretaryDetails).to.be.undefined;
@@ -554,6 +561,7 @@ describe("update a certificate PATCH", () => {
             },
             includeCompanyObjectsInformation: true,
             includeEmailCopy: true,
+            includeGeneralNatureOfBusinessInformation: true,
             includeGoodStandingInformation: true,
             limitedPartnerDetails: {
                 includeBasicInformation: true
@@ -649,6 +657,7 @@ describe("update a certificate PATCH", () => {
         expect(io.generalPartnerDetails.includeBasicInformation).to.equal(mockIo.general_partner_details.include_basic_information);
         expect(io.includeCompanyObjectsInformation).to.equal(mockIo.include_company_objects_information);
         expect(io.includeEmailCopy).to.equal(mockIo.include_email_copy);
+        expect(io.includeGeneralNatureOfBusinessInformation).to.equal(mockIo.include_general_nature_of_business_information);
         expect(io.includeGoodStandingInformation).to.equal(mockIo.include_good_standing_information);
         expect(io.limitedPartnerDetails.includeBasicInformation).to.equal(mockIo.limited_partner_details.include_basic_information);
         expect(io.memberDetails.includeAddress).to.equal(mockIo.member_details.include_address);
@@ -695,6 +704,7 @@ describe("update a certificate PATCH", () => {
         expect(io.forename).to.equal(mockIo.forename);
         expect(io.includeCompanyObjectsInformation).to.equal(mockIo.include_company_objects_information);
         expect(io.includeEmailCopy).to.equal(mockIo.include_email_copy);
+        expect(io.includeGeneralNatureOfBusinessInformation).to.equal(mockIo.include_general_nature_of_business_information);
         expect(io.includeGoodStandingInformation).to.equal(mockIo.include_good_standing_information);
         expect(io.registeredOfficeAddressDetails).to.be.undefined;
         expect(io.secretaryDetails).to.be.undefined;

test/services/order/service.spec.ts

@@ -67,6 +67,7 @@ const mockCertificateOrderResponseBody: OrderResource = {
             general_partner_details: {},
             limited_partner_details: {},
             member_details: {},
+            include_general_nature_of_business_information: true,
             include_good_standing_information: true,
             principle_place_of_business_details: {},
             registered_office_address_details: {},
@@ -366,6 +367,7 @@ describe("order", () => {
             expect(itemOptions.deliveryTimescale).to.equal(itemOptionsResource.delivery_timescale);
             expect(itemOptions.directorDetails.includeBasicInformation).to.equal(itemOptionsResource.director_details.include_basic_information);
             expect(itemOptions.forename).to.equal(itemOptionsResource.forename);
+            expect(itemOptions.includeGeneralNatureOfBusinessInformation).to.equal(itemOptionsResource.include_general_nature_of_business_information);
             expect(itemOptions.includeGoodStandingInformation).to.equal(itemOptionsResource.include_good_standing_information);
             expect(itemOptions.registeredOfficeAddressDetails).to.be.undefined;
             expect(itemOptions.secretaryDetails).to.be.undefined;