Merge pull request #757 from companieshouse/lp-238-update-general-partner

LP-301 update general partner

Author: markpit

src/services/limited-partnerships/service.ts

@@ -64,7 +64,7 @@ export default class LimitedPartnershipsService {
         transactionId: string,
         filingResourceId: string,
         includeSubResources?: boolean): Promise<Resource<LimitedPartnershipIncorporation> | ApiErrorResponse> {
-        const subResourcesQuery :string = (includeSubResources ? ("?include_sub_resources=" + includeSubResources) : "");
+        const subResourcesQuery: string = (includeSubResources ? ("?include_sub_resources=" + includeSubResources) : "");
         const URL = `/transactions/${transactionId}/incorporation/limited-partnership/${filingResourceId}${subResourcesQuery}`;
 
         const response: HttpResponse = await this.client.httpGet(URL);

src/services/limited-partnerships/types.ts

@@ -20,20 +20,21 @@ export interface LimitedPartnership {
 
 export interface GeneralPartner {
     data?: {
-        country?: string,
         date_effective_from?: string,
         date_of_birth?: string,
         etag?: string,
         forename?: string,
         former_names?: string,
         governing_law?: string,
         kind?: string,
+        legal_entity_name?: string,
         legal_entity_register_name?: string,
         legal_entity_registration_location?: string,
         legal_form?: string,
         nationality1?: string,
         nationality2?: string,
         not_disqualified_statement_checked?: boolean,
+        legal_personality_statement_checked?: boolean,
         principal_office_address?: Address,
         registered_company_number?: string,
         resignation_date?: string,

test/services/limited-partnerships/limited.partnerships.mock.ts

@@ -46,20 +46,21 @@ export const LIMITED_PARTNERSHIP_OBJECT_MOCK: LimitedPartnership = {
 
 export const GENERAL_PARTNER_OBJECT_MOCK: GeneralPartner = {
     data: {
-        country: "England",
         date_effective_from: "2005-02-04",
         date_of_birth: "2000-05-01",
         etag: "",
         forename: "John",
         former_names: "Mary",
         governing_law: "British Government",
         kind: "",
-        legal_entity_register_name: "Entity Name",
-        legal_entity_registration_location: "UK",
-        legal_form: "",
+        legal_entity_name: "My company ltd",
+        legal_entity_register_name: "UK Register",
+        legal_entity_registration_location: "England",
+        legal_form: "abc",
         nationality1: "English",
         nationality2: "French",
         not_disqualified_statement_checked: true,
+        legal_personality_statement_checked: true,
         principal_office_address: {
             premises: "22",
             address_line_1: "Some Street",