migrate httpPut functionaity from old sdk to new

Author: macreman

src/http/http-client.ts

@@ -66,6 +66,7 @@ export default interface IHttpClient {
   httpGet(url: string): Promise<HttpResponse>;
   httpPost(url: string, body?: any): Promise<HttpResponse>;
   httpPatch(url: string, body?: any, headers?: Headers): Promise<HttpResponse>;
+  httpPut(url: string, body?: any, headers?: Headers): Promise<HttpResponse>;
   httpDelete(url: string): Promise<HttpResponse>;
 }
 
@@ -127,6 +128,8 @@ export abstract class AbstractClient implements IHttpClient {
 
   public abstract httpPatch(url: string, body?: any, headers?: Headers): Promise<HttpResponse>;
 
+  public abstract httpPut(url: string, body?: any, headers?: Headers): Promise<HttpResponse>;
+
   public abstract httpDelete(url: string): Promise<HttpResponse>;
 
   private init () {

src/http/request-client.ts

@@ -18,6 +18,10 @@ export default class RequestClient extends AbstractClient {
         return this.request({ method: "PATCH", url, body, headers });
     }
 
+    public async httpPut (url: string, body?: any, headers?: Headers): Promise<HttpResponse> {
+        return this.request({ method: "PUT", url, body, headers });
+    }
+
     public async httpDelete (url: string): Promise<HttpResponse> {
         return this.request({ method: "DELETE", url });
     }

test/http/http-client.spec.ts

@@ -11,6 +11,10 @@ class TestClient extends AbstractClient {
         throw new Error("Method not implemented.");
     }
 
+    public httpPut (url: string, body: any, headers: any): Promise<HttpResponse> {
+        throw new Error("Method not implemented.");
+    }
+
     public httpDelete (url: string): Promise<HttpResponse> {
         throw new Error("Method not implemented.");
     }

test/http/request-client.spec.ts

@@ -124,6 +124,42 @@ describe("request-client", () => {
         expect(resp.status).to.equal(statusCode);
     });
 
+    it("returns an error response when HTTP PUT request fails", async () => {
+        const returnedBody = { error: "company not found" };
+        const statusCode = 404;
+
+        const rejectedValue = {
+            status: statusCode,
+            response: {
+                body: returnedBody
+            }
+        };
+
+        const mockRequest = sinon.stub(client, "request" as any).rejects(rejectedValue).returns(rejectedValue);
+        const resp = await client.httpPut("/foo", { data: "bar" }, { content: "bob" });
+
+        expect(mockRequest).to.have.been.calledOnce;
+        expect(resp.status).to.equal(statusCode);
+    });
+
+    it("returns the correct body for successful PUT calls", async () => {
+        const body = { ok: true };
+        const statusCode = 200;
+
+        const resolvedValue = {
+            status: statusCode,
+            body: body
+        };
+
+        const mockRequest = sinon.stub(client, "request" as any).resolves(resolvedValue);
+        const resp = await client.httpPut("/foo", { data: "bar" }, { content: "bob" });
+
+        expect(mockRequest).to.have.been.calledOnce;
+        expect(resp.error).to.be.undefined;
+        expect(resp.body).to.deep.equal(body);
+        expect(resp.status).to.equal(statusCode);
+    });
+
     it("returns an error response when HTTP DELETE request fails", async () => {
         const returnedBody = { error: "not found" };
         const statusCode = 404;