Merge pull request #834 from companieshouse/feature/DEEP-620-updating-isValid-to-valid-to-match-backend-api

Updating ValidationStatusResponse interface from isValid to valid to match backend api

Author: cbroadley-ch

src/services/psc-extensions-link/types.ts

@@ -155,7 +155,7 @@ export interface ValidationStatusError {
 }
 export interface ValidationStatusResponse {
     errors: ValidationStatusError[];
-    isValid?: boolean;
+    valid: boolean;
 }
 export interface ValidationStatusErrorResource {
     error: string;
@@ -165,5 +165,5 @@ export interface ValidationStatusErrorResource {
 }
 export interface ValidationStatusResponseResource {
     errors: ValidationStatusErrorResource[];
-    is_valid?: boolean;
+    valid: boolean;
 }

test/services/psc-extensions-link/service.mock.ts

@@ -46,17 +46,17 @@ export const PSC_EXTENSION: PscExtension = {
 };
 
 const VALIDATION_STATUS_RESPONSE_RESOURCE = {
-    is_valid: true,
+    valid: true,
     errors: []
 };
 
 export const VALIDATION_STATUS_RESPONSE: ValidationStatusResponse = {
-    isValid: true,
+    valid: true,
     errors: []
 };
 
 const VALIDATION_STATUS_RESPONSE_INVALID_RESOURCE = {
-    is_valid: false,
+    valid: false,
     errors: [
         {
             error: "PSC has exceeded maximum number of extension requests",
@@ -68,7 +68,7 @@ const VALIDATION_STATUS_RESPONSE_INVALID_RESOURCE = {
 };
 
 export const VALIDATION_STATUS_RESPONSE_INVALID: ValidationStatusResponse = {
-    isValid: false,
+    valid: false,
     errors: [
         {
             error: "PSC has exceeded maximum number of extension requests",

test/services/psc-extensions-link/service.spec.ts

@@ -155,7 +155,7 @@ describe("PSC Extensions Service", () => {
                 TRANSACTION_ID, PSC_NOTIFICATION_ID, COMPANY_NUMBER)) as Resource<ValidationStatusResponse>;
 
             expect(response.httpStatusCode).to.equal(StatusCodes.OK);
-            expect(response.resource!.isValid).to.be.true;
+            expect(response.resource!.valid).to.be.true;
             expect(response.resource!.errors).to.be.empty;
         });
 
@@ -166,7 +166,7 @@ describe("PSC Extensions Service", () => {
                 TRANSACTION_ID, PSC_NOTIFICATION_ID, COMPANY_NUMBER)) as Resource<ValidationStatusResponse>;
 
             expect(response.httpStatusCode).to.equal(StatusCodes.OK);
-            expect(response.resource!.isValid).to.be.false;
+            expect(response.resource!.valid).to.be.false;
             expect(response.resource!.errors).to.have.length(1);
             expect(response.resource!.errors[0].error).to.equal("PSC has exceeded maximum number of extension requests");
         });