Skip to content

Commit ba95c9c

Browse files
authored
Merge pull request #14 from companieshouse/release/4.26.0
Release/4.26.0
2 parents 965bafd + 62cb0a6 commit ba95c9c

File tree

8 files changed

+68
-12
lines changed

8 files changed

+68
-12
lines changed

api-enumerations

appconfig.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,6 @@ feature:
9393

9494
image_service_start_date: <IMAGE_SERVICE_START_DATE>
9595

96-
disable_download_xhtml_link: <DISABLE_DOWNLOAD_XHTML_LINK>
97-
9896
recently_filed_days: <RECENTLY_FILED_DAYS>
9997

10098
unavailable_date: <UNAVAILABLE_DATE>

cpanfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ requires 'Mojolicious', '==5.47';
1111
requires 'Moose', '==2.1402';
1212

1313
requires 'CH::MojoX::Administration::Plugin', '==0.35';
14-
requires 'Net::CompaniesHouse::Admin', '==0.35'
14+
requires 'Net::CompaniesHouse::Admin', '==0.36'
1515
requires 'Net::CompaniesHouse', '==0.65';
1616
requires 'CH::MojoX::Plugin::API', '==0.40';
1717
requires 'CH::MojoX::Plugin::Config', '==0.31';

lib/ChGovUk/Controllers/Admin/Transaction.pm

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -240,8 +240,50 @@ sub transaction_json {
240240

241241
$self->_get_new_transaction($delay, $delay->begin(0));
242242
}
243+
243244
#-------------------------------------------------------------------------------
244245

246+
sub transaction_reprocess {
247+
my ($self) = @_;
248+
249+
$self->render_later;
250+
251+
my $transaction_id = $self->stash('transaction_number');
252+
253+
$self->ch_api->private->transactions($transaction_id)->reprocess->create->on(
254+
success => sub {
255+
my ($api, $tx) = @_;
256+
257+
return $self->render;
258+
},
259+
failure => sub {
260+
my ($api, $tx) = @_;
261+
my $error_code = $tx->error->{code} // 0;
262+
my $error_message = $tx->error->{message};
263+
264+
my $message;
265+
266+
if (defined $error_code and $error_code == 403) {
267+
$message = sprintf 'Transaction [%s] - Failed to reprocess non-closed transaction [%s]: [%s]', $transaction_id, $error_code, $error_message;
268+
} else {
269+
$message = sprintf 'Transaction [%s] - Failure occurred reprocessing transaction [%s]: [%s]', $transaction_id, $error_code, $error_message;
270+
}
271+
272+
error $message [ADMIN TRANSACTION_REPROCESS];
273+
return $self->render_exception($message);
274+
},
275+
error => sub {
276+
my ($api, $error) = @_;
277+
278+
my $message = sprintf 'Transaction [%s] - Error occurred reprocessing transaction: [%s]', $transaction_id, $error;
279+
280+
error $message [ADMIN TRANSACTION_REPROCESS];
281+
return $self->render_exception($message);
282+
}
283+
)->execute;
284+
}
285+
286+
#-------------------------------------------------------------------------------
245287

246288
sub resource_json {
247289
my ($self) = @_;

lib/ChGovUk/Controllers/Company/FilingHistory.pm

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,6 @@ sub view {
4747
$self->stash->{image_service_active} = $self->can_view_images;
4848
# FIXME: ^^^ Remove this when Doc API goes live (and in template) ^^^
4949

50-
# FIXME: vvv Remove this when XBRL is working (and in template) vvv
51-
my $disable_download_xhtml_link = $self->config->{disable_download_xhtml_link} || 0;
52-
$self->stash(disable_download_xhtml_link => $disable_download_xhtml_link);
53-
# FIXME: ^^^ Remove this when XBRL is working (and in template) ^^^
54-
5550
# FIXME: remove this when confirmation-statement goes live - also in template
5651
my $confirmation_statement_available_date = $self->config->{confirmation_statement_available_date} || '2016-06-30';
5752

lib/ChGovUk/Plugins/Admin/Routes.pm

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ sub register {
2828
$admin_route->get('/transactions/:transaction_number')->to('admin-transaction#filing');
2929
$admin_route->get('/company/:company_number/transactions')->name('admin_transaction_by_company_number')->to('admin-transaction#search_by_company_number');
3030
$admin_route->get('/view_json')->name('admin_transaction_resource_details')->to('admin-transaction#submission_json');
31-
$transaction->get ('/details')->name('admin_transaction_details')->to('admin-transaction#transaction_json');
31+
$transaction->get('/details')->name('admin_transaction_details')->to('admin-transaction#transaction_json');
32+
$transaction->post('/reprocess')->name('admin_transaction_reprocess')->to('admin-transaction#transaction_reprocess');
3233

3334
my $filing = $transaction->route('/:barcode');
3435
$filing->get ('/email')->name('admin_email_view')->to('admin-transaction#email_confirm');
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
% cascade base {title => 'Transaction reprocess request', searchpage => 1, classes=>"search ancillary", disable_header_search => 1}
2+
3+
% around content -> {
4+
<a class="link-back" id="back-button" href="javascript:history.back()">Back</a>
5+
6+
<div class="inner-block">
7+
% include includes::page_header {title => $title}
8+
9+
Transaction <% $transaction_number %> will be reprocessed.
10+
</div>
11+
% }

templates/includes/transactions.tx

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,17 @@
3030
% }
3131

3232
% if $c.can_do('/admin/transaction-lookup') {
33-
34-
<td><a class="admin-link" id="view-transaction-<% $~transaction %>" href="<% $c.url_for('admin_transaction_details', transaction_number => $transaction.id) %>"> View transaction</a></td>
33+
<a class="admin-link" id="view-transaction-<% $~transaction %>" href="<% $c.url_for('admin_transaction_details', transaction_number => $transaction.id) %>"> View transaction</a>
34+
% }
35+
36+
% if $c.can_do('/admin/transaction-reprocess') && $transaction.status == "closed" {
37+
38+
<form method="post" action="<% $c.url_for('admin_transaction_reprocess', transaction_number => $transaction.id) %>">
39+
<div class="form-group">
40+
<input type="submit" id="reprocess" name="reprocess" class="admin-link" value="Reprocess transaction">
41+
</div>
42+
</form>
43+
3544
% }
3645
</div>
3746
<div class="column-third column-reference" id="reference-number-<% $~transaction.count %>">

0 commit comments

Comments
 (0)