Skip to content

Charges tab not visible with JS disabled due to unclosed div #221

@hlandau

Description

@hlandau

When JS is disabled nothing is shown under the "charges" tab. This appears to be due to an unclosed js-only div shown here:

<div class="js-only">
<form id="mortgage-filter" class="form grid-row">
<div class="column-half">
<h2 class="heading-medium"><% l('Filter charges') %></h2>
<fieldset>
<legend class="visuallyhidden">Filter charges</legend>
% for $filters -> $filter {
<label id="filter-<% $filter.id %>_label" for="filter-<% $filter.id %>" class="block-label selection-button-checkbox">
<input id="filter-<% $filter.id %>" name="filter" value="<% $filter.id %>" type="checkbox" <% $filter.checked ? 'checked' : '' %> />
<% l($filter.name) %>
</label>
% if $~filter.count == $split_filter_at {
</div>
<div class="column-quarter">
% }
% }
</fieldset>
<input id="submit-filter" class="button js-hidden" type="submit" value="<% l('Apply filter') %>">
</form>
</div>

The indentation suggests this tag is closed, but the HTML inside it is not closed correctly, thus all remaining content falls under js-only.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions