Skip to content

Commit 55b2c1b

Browse files
authored
Merge pull request #51 from companieshouse/lp-314-store-partnership-type-mongo
Lp 314 store partnership type mongo
2 parents 16417da + e4b6437 commit 55b2c1b

File tree

5 files changed

+40
-0
lines changed

5 files changed

+40
-0
lines changed

spec/schema.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,10 @@
154154
"name_ending": {
155155
"type": "string",
156156
"enum": ["Limited Partnership", "LP", "L.P.", "Partneriaeth Cyfyngedig", "PC", "P.C."]
157+
},
158+
"partnership_type": {
159+
"type": "string",
160+
"enum": ["LP", "PFLP", "SLP", "SPFLP"]
157161
}
158162
}
159163
},
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
package uk.gov.companieshouse.limitedpartnershipsapi.model;
2+
3+
public enum PartnershipType {
4+
LP,
5+
PFLP,
6+
SLP,
7+
SPFLP
8+
}

src/main/java/uk/gov/companieshouse/limitedpartnershipsapi/model/dao/DataDao.java

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package uk.gov.companieshouse.limitedpartnershipsapi.model.dao;
22

33
import org.springframework.data.mongodb.core.mapping.Field;
4+
import uk.gov.companieshouse.limitedpartnershipsapi.model.PartnershipType;
45

56
public class DataDao {
67

@@ -13,6 +14,9 @@ public class DataDao {
1314
@Field("registered_email_address")
1415
private String email;
1516

17+
@Field("partnership_type")
18+
private PartnershipType partnershipType;
19+
1620
public String getPartnershipName() {
1721
return partnershipName;
1822
}
@@ -36,4 +40,12 @@ public String getEmail() {
3640
public void setEmail(String email) {
3741
this.email = email;
3842
}
43+
44+
public PartnershipType getPartnershipType() {
45+
return partnershipType;
46+
}
47+
48+
public void setPartnershipType(PartnershipType partnershipType) {
49+
this.partnershipType = partnershipType;
50+
}
3951
}

src/main/java/uk/gov/companieshouse/limitedpartnershipsapi/model/dto/DataDto.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import com.fasterxml.jackson.annotation.JsonInclude;
44
import com.fasterxml.jackson.annotation.JsonProperty;
55
import uk.gov.companieshouse.limitedpartnershipsapi.model.PartnershipNameEnding;
6+
import uk.gov.companieshouse.limitedpartnershipsapi.model.PartnershipType;
67

78
import static com.fasterxml.jackson.annotation.JsonInclude.Include.NON_NULL;
89

@@ -18,6 +19,10 @@ public class DataDto {
1819
@JsonProperty("email")
1920
private String email;
2021

22+
@JsonInclude(NON_NULL)
23+
@JsonProperty("partnership_type")
24+
private PartnershipType partnershipType;
25+
2126
public String getPartnershipName() {
2227
return partnershipName;
2328
}
@@ -41,4 +46,12 @@ public String getEmail() {
4146
public void setEmail(String email) {
4247
this.email = email;
4348
}
49+
50+
public PartnershipType getPartnershipType() {
51+
return partnershipType;
52+
}
53+
54+
public void setPartnershipType(PartnershipType partnershipType) {
55+
this.partnershipType = partnershipType;
56+
}
4457
}

src/test/java/uk/gov/companieshouse/limitedpartnershipsapi/mapper/LimitedPartnerMapperTest.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import org.junit.jupiter.api.Test;
44
import org.mockito.InjectMocks;
55
import uk.gov.companieshouse.limitedpartnershipsapi.model.PartnershipNameEnding;
6+
import uk.gov.companieshouse.limitedpartnershipsapi.model.PartnershipType;
67
import uk.gov.companieshouse.limitedpartnershipsapi.model.dao.DataDao;
78
import uk.gov.companieshouse.limitedpartnershipsapi.model.dao.LimitedPartnershipSubmissionDao;
89
import uk.gov.companieshouse.limitedpartnershipsapi.model.dto.DataDto;
@@ -23,6 +24,7 @@ void givenDto_whenMapsToDao_thenCorrect() {
2324
DataDto sourceData = new DataDto();
2425
sourceData.setPartnershipName("Joe Bloggs");
2526
sourceData.setNameEnding(PartnershipNameEnding.LIMITED_PARTNERSHIP);
27+
sourceData.setPartnershipType(PartnershipType.LP);
2628
source.setData(sourceData);
2729

2830
// when
@@ -32,6 +34,7 @@ void givenDto_whenMapsToDao_thenCorrect() {
3234
DataDao destinationData = destination.getData();
3335
assertEquals(sourceData.getPartnershipName(), destinationData.getPartnershipName());
3436
assertEquals(sourceData.getNameEnding().getDescription(), destinationData.getNameEnding());
37+
assertEquals(sourceData.getPartnershipType(), destinationData.getPartnershipType());
3538
}
3639

3740
@Test

0 commit comments

Comments
 (0)