Merge pull request #49 from companieshouse/sonar-code-smells

Fix some minor sonar code smells

Author: markpit

src/main/java/uk/gov/companieshouse/limitedpartnershipsapi/model/dto/LimitedPartnershipSubmissionCreatedResponseDto.java

@@ -2,4 +2,6 @@
 
 import com.fasterxml.jackson.annotation.JsonProperty;
 
-public record LimitedPartnershipSubmissionCreatedResponseDto(@JsonProperty("id") String id) {}
+public record LimitedPartnershipSubmissionCreatedResponseDto(
+        @JsonProperty("id") String id) {
+}

src/test/java/uk/gov/companieshouse/limitedpartnershipsapi/mapper/LimitedPartnerMapperTest.java

@@ -2,7 +2,6 @@
 
 import org.junit.jupiter.api.Test;
 import org.mockito.InjectMocks;
-import org.springframework.beans.factory.annotation.Autowired;
 import uk.gov.companieshouse.limitedpartnershipsapi.model.PartnershipNameEnding;
 import uk.gov.companieshouse.limitedpartnershipsapi.model.dao.DataDao;
 import uk.gov.companieshouse.limitedpartnershipsapi.model.dao.LimitedPartnershipSubmissionDao;
@@ -12,13 +11,13 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
-public class LimitedPartnerMapperTest {
+class LimitedPartnerMapperTest {
 
     @InjectMocks
     LimitedPartnershipMapper mapper;
 
     @Test
-    public void givenDto_whenMapsToDao_thenCorrect() {
+    void givenDto_whenMapsToDao_thenCorrect() {
         // given
         LimitedPartnershipSubmissionDto source = new LimitedPartnershipSubmissionDto();
         DataDto sourceData = new DataDto();
@@ -36,7 +35,7 @@ public void givenDto_whenMapsToDao_thenCorrect() {
     }
 
     @Test
-    public void givenNameEndingEnum_whenMapsToString_thenCorrect(){
+    void givenNameEndingEnum_whenMapsToString_thenCorrect(){
         // given
         PartnershipNameEnding sourceData = PartnershipNameEnding.LIMITED_PARTNERSHIP;
         // when
@@ -46,7 +45,7 @@ public void givenNameEndingEnum_whenMapsToString_thenCorrect(){
     }
 
     @Test
-    public void givenNameEndingString_whenMapsToENum_thenCorrect(){
+    void givenNameEndingString_whenMapsToENum_thenCorrect(){
         // given
         String sourceData = PartnershipNameEnding.LIMITED_PARTNERSHIP.getDescription();
         // when
@@ -56,7 +55,7 @@ public void givenNameEndingString_whenMapsToENum_thenCorrect(){
     }
 
     @Test
-    public void givenInvalidNameEndingString_whenMapsToEnum_thenIllegalArgumentException(){
+    void givenInvalidNameEndingString_whenMapsToEnum_thenIllegalArgumentException(){
         // given
         String invalidNameEnding = "Invalid Name Ending";
         // then

src/test/java/uk/gov/companieshouse/limitedpartnershipsapi/service/LimitedPartnershipServiceTest.java

@@ -30,7 +30,7 @@
 import static uk.gov.companieshouse.limitedpartnershipsapi.utils.Constants.FILING_KIND_LIMITED_PARTNERSHIP;
 
 @ExtendWith(MockitoExtension.class)
-public class LimitedPartnershipServiceTest {
+class LimitedPartnershipServiceTest {
 
     private static final String USER_ID = "xbJf0l";
     private static final String SUBMISSION_ID = "abc-123";