LP-909 comments and formatting

Author: mattch1

src/presentation/test/builder/AbstractPartnerBuilder.ts

@@ -91,7 +91,7 @@ abstract class AbstractPartnerBuilder {
   }
 
   withLegalEntityRegistrationLocation(country: string) {
-    this.data.legal_entity_registration_location = country
+    this.data.legal_entity_registration_location = country;
     return this;
   }
 }

src/presentation/test/integration/postTransition/generalPartner/general-partner-check-your-answers-legal-entity.test.ts

@@ -26,10 +26,10 @@ describe("Check Your Answers Page", () => {
     appDevDependencies.companyGateway.feedCompanyProfile(companyProfile.data);
 
     generalPartnerLegalEntity = new GeneralPartnerBuilder()
-    .isLegalEntity()
-    .withDateEffectiveFrom("2024-10-10")
-    .withLegalEntityRegistrationLocation("Wales")
-    .build();
+      .isLegalEntity()
+      .withDateEffectiveFrom("2024-10-10")
+      .withLegalEntityRegistrationLocation("Wales")
+      .build();
     appDevDependencies.generalPartnerGateway.feedGeneralPartners([generalPartnerLegalEntity]);
   });
 

src/presentation/test/integration/postTransition/generalPartner/general-partner-check-your-answers-person.test.ts

@@ -26,11 +26,11 @@ describe("General Partner Check Your Answers Page", () => {
     appDevDependencies.companyGateway.feedCompanyProfile(companyProfile.data);
 
     generalPartnerPerson = new GeneralPartnerBuilder()
-    .isPerson()
-    .withFormerNames("Joe Dee")
-    .withDateEffectiveFrom("2024-10-10")
-    .withNationality1("Welsh")
-    .build();
+      .isPerson()
+      .withFormerNames("Joe Dee")
+      .withDateEffectiveFrom("2024-10-10")
+      .withNationality1("Welsh")
+      .build();
     appDevDependencies.generalPartnerGateway.feedGeneralPartners([generalPartnerPerson]);
   });
 
@@ -47,7 +47,7 @@ describe("General Partner Check Your Answers Page", () => {
     expect(res.text).not.toContain("WELSH -");
   });
 
-  it("should GET Check Your Answers Page Welsh text for person", async () => {
+  it("should GET Check Your Answers Page Welsh text", async () => {
     setLocalesEnabled(true);
     const res = await request(app).get(URL + "?lang=cy");
 

src/presentation/test/integration/postTransition/limitedPartner/limited-partner-check-your-answers-legal-entity.test.ts

@@ -26,10 +26,11 @@ describe("Limited Partner Check Your Answers Page", () => {
     appDevDependencies.companyGateway.feedCompanyProfile(companyProfile.data);
 
     limitedPartnerLegalEntity = new LimitedPartnerBuilder()
-    .isLegalEntity()
-    .withDateEffectiveFrom("2024-10-10")
-    .withLegalEntityRegistrationLocation("Wales")
-    .build();
+      .isLegalEntity()
+      .withDateEffectiveFrom("2024-10-10")
+      .withLegalEntityRegistrationLocation("Wales")
+      .build();
+
     appDevDependencies.limitedPartnerGateway.feedLimitedPartners([limitedPartnerLegalEntity]);
   });
 

src/presentation/test/integration/postTransition/limitedPartner/limited-partner-check-your-answers-person.test.ts

@@ -26,11 +26,12 @@ describe("Limited Partner Check Your Answers Page for Person", () => {
     appDevDependencies.companyGateway.feedCompanyProfile(companyProfile.data);
 
     limitedPartnerPerson = new LimitedPartnerBuilder()
-    .isPerson()
-    .withFormerNames("Joe Dee")
-    .withDateEffectiveFrom("2024-10-10")
-    .withNationality1("Welsh")
-    .build();
+      .isPerson()
+      .withFormerNames("Joe Dee")
+      .withDateEffectiveFrom("2024-10-10")
+      .withNationality1("Welsh")
+      .build();
+
     appDevDependencies.limitedPartnerGateway.feedLimitedPartners([limitedPartnerPerson]);
   });
 
@@ -57,7 +58,7 @@ describe("Limited Partner Check Your Answers Page for Person", () => {
     expect(res.text).toContain(cyTranslationText.checkYourAnswersPage.update.title);
     expect(res.text).toContain(cyTranslationText.print.buttonText);
     expect(res.text).toContain(cyTranslationText.print.buttonTextNoJs);
-     expect(res.text).toContain(cyTranslationText.nationalities.welsh);
+    expect(res.text).toContain(cyTranslationText.nationalities.welsh);
     testTranslations(res.text, cyTranslationText.checkYourAnswersPage.warningMessage);
     expect(res.text).toContain("WELSH -");
   });

src/presentation/test/integration/postTransition/limitedPartnership/checkYourAnswer/principal-place-of-business-address-change-check-your-answers.test.ts

@@ -40,7 +40,7 @@ describe("Principal place of business address check your answers page", () => {
       //  change links should retain the lang query parameter
       expect(res.text).toContain(`${ENTER_PRINCIPAL_PLACE_OF_BUSINESS_ADDRESS_TEMPLATE}?lang=en`);
       expect(res.text).toContain(`${WHEN_DID_THE_PRINCIPAL_PLACE_OF_BUSINESS_ADDRESS_CHANGE_TEMPLATE}?lang=en`);
-    
+
       expect(res.text).toContain(enTranslationText.countries.england);
     });
 
@@ -57,7 +57,7 @@ describe("Principal place of business address check your answers page", () => {
       //  change links should retain the lang query parameter
       expect(res.text).toContain(`${ENTER_PRINCIPAL_PLACE_OF_BUSINESS_ADDRESS_TEMPLATE}?lang=cy`);
       expect(res.text).toContain(`${WHEN_DID_THE_PRINCIPAL_PLACE_OF_BUSINESS_ADDRESS_CHANGE_TEMPLATE}?lang=cy`);
-    
+
       expect(res.text).toContain(cyTranslationText.countries.england);
     });
   });

src/views/includes/macros.njk

@@ -79,6 +79,7 @@
   {%- set words = localeStr.split(' ') -%}
   {%- set result = [] -%}
 
+  {# Temporary while waiting for welsh translations - need to handle 'WELSH -' keyword #}
   {%- if words[0] === "WELSH" -%}
     {%- set result = result.concat(words[0]) -%}
     {%- set result = result.concat(words[1]) -%}
@@ -125,6 +126,7 @@
   {{ term }}
 {% endmacro %}
 
+{# Required as keys for looking up the locale #}
 {%- macro makeCamelCase(str) -%}
   {%- set str = str.replace("-", " ") -%}    
   {%- set words = str.split(' ') -%}