Merge pull request #595 from companieshouse/lp-1346-trim-company-number-input

LP-1346 Trailing spaces in company number should be valid

Author: mattch1

src/presentation/controller/postTransition/LimitedPartnershipController.ts

@@ -123,20 +123,20 @@ class LimitedPartnershipController extends AbstractController {
         const pageRouting = super.getRouting(postTransitionRouting, pageType, request);
         const { company_number } = request.body;
 
-        const result = await this.companyService.buildLimitedPartnershipFromCompanyProfile(tokens, company_number);
+        const result = await this.companyService.buildLimitedPartnershipFromCompanyProfile(tokens, company_number.trim());
 
         if (result.errors) {
           response.render(
             super.templateName(pageRouting.currentUrl),
-            super.makeProps(pageRouting, { company_number }, result.errors)
+            super.makeProps(pageRouting, { company_number: company_number.trim() }, result.errors)
           );
 
           return;
         }
 
         const url = super.insertIdsInUrl(pageRouting.nextUrl, {
           ...ids,
-          companyId: company_number
+          companyId: company_number.trim()
         });
 
         response.redirect(url);

src/presentation/controller/transition/LimitedPartnershipController.ts

@@ -188,18 +188,18 @@ class LimitedPartnershipController extends PartnershipController {
         const pageRouting = super.getRouting(transitionRouting, pageType, request);
         const { company_number } = request.body;
 
-        const result = await this.companyService.buildLimitedPartnershipFromCompanyProfile(tokens, company_number);
+        const result = await this.companyService.buildLimitedPartnershipFromCompanyProfile(tokens, company_number.trim());
 
         if (result.errors) {
           response.render(
             super.templateName(pageRouting.currentUrl),
-            super.makeProps(pageRouting, { company_number }, result.errors)
+            super.makeProps(pageRouting, { company_number: company_number.trim() }, result.errors)
           );
 
           return;
         }
 
-        const url = super.insertIdsInUrl(pageRouting.nextUrl, { ...ids, companyId: company_number }, request.url);
+        const url = super.insertIdsInUrl(pageRouting.nextUrl, { ...ids, companyId: company_number.trim() }, request.url);
 
         response.redirect(url);
       } catch (error) {

src/presentation/test/integration/postTransition/company-number.test.ts

@@ -65,6 +65,18 @@ describe("Company number page", () => {
       expect(res.text).toContain(`Redirecting to ${REDIRECT_URL}`);
     });
 
+    it("should redirect to confirmation page if company_number has trailing spaces", async () => {
+      const res = await request(app).post(URL).send({
+        pageType: TransitionPageType.companyNumber,
+        company_number: "LP123456 "
+      });
+
+      const REDIRECT_URL = getUrl(CONFIRM_LIMITED_PARTNERSHIP_URL);
+
+      expect(res.status).toBe(302);
+      expect(res.text).toContain(`Redirecting to ${REDIRECT_URL}`);
+    });
+
     it("should return an error if company_number is not valid", async () => {
       appDevDependencies.companyGateway.setError(true);
 

src/presentation/test/integration/transition/company-number.test.ts

@@ -65,6 +65,18 @@ describe("Company number page", () => {
       expect(res.text).toContain(`Redirecting to ${REDIRECT_URL}`);
     });
 
+    it("should redirect to confirmation page if company_number has trailing spaces", async () => {
+      const res = await request(app).post(URL).send({
+        pageType: TransitionPageType.companyNumber,
+        company_number: "LP123456 "
+      });
+
+      const REDIRECT_URL = getUrl(CONFIRM_LIMITED_PARTNERSHIP_URL);
+
+      expect(res.status).toBe(302);
+      expect(res.text).toContain(`Redirecting to ${REDIRECT_URL}`);
+    });
+
     it("should return an error if company_number is not valid", async () => {
       appDevDependencies.companyGateway.setError(true);