Merge pull request #610 from companieshouse/fix/lp-925-postcode-error-message

lduranteau · web-flow · commit c03605933664 · 2025-11-26T08:24:36.000Z
lp-925 : remove postcode html validation
diff --git a/locales/cy/translations.json b/locales/cy/translations.json
@@ -223,7 +223,6 @@
                 "localityLength": "WELSH - Town or city must be 50 characters or less",
                 "regionLength": "WELSH - County, state, province or region must be 50 characters or less",
                 "postcodeMissing": "WELSH - Enter a postcode",
-                "postcodeLength": "WELSH - Postcode must be 15 characters or less",
                 "postcodeFormat": "WELSH - Invalid postcode format",
                 "countryMissing": "WELSH - Select a country",
                 "jurisdictionCountry": "WELSH - You must enter a country that matches your jurisdiction",
diff --git a/locales/en/translations.json b/locales/en/translations.json
@@ -224,7 +224,6 @@
                 "localityLength": "Town or city must be 50 characters or less",
                 "regionLength": "County, state, province or region must be 50 characters or less",
                 "postcodeMissing": "Enter a postcode",
-                "postcodeLength": "Postcode must be 15 characters or less",
                 "postcodeFormat": "Invalid postcode format",
                 "countryMissing": "Select a country",
                 "jurisdictionCountry": "You must enter a country that matches your jurisdiction",
diff --git a/src/presentation/test/integration/postTransition/generalPartner/address/enter-general-partner-correspondence-address.test.ts b/src/presentation/test/integration/postTransition/generalPartner/address/enter-general-partner-correspondence-address.test.ts
@@ -54,7 +54,6 @@ describe("Enter Correspondence Address Page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "usualResidentialAddress",
         "principalOfficeAddress",
         "limitedPartner",
@@ -89,7 +88,6 @@ describe("Enter Correspondence Address Page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "postcode",
         "usualResidentialAddress",
         "limitedPartner",
diff --git a/src/presentation/test/integration/postTransition/generalPartner/address/enter-general-partner-principal-office-address.test.ts b/src/presentation/test/integration/postTransition/generalPartner/address/enter-general-partner-principal-office-address.test.ts
@@ -44,7 +44,6 @@ describe("Enter general partner's principal office manual address page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "usualResidentialAddress",
         "correspondenceAddress",
         "principalOfficeAddress",
@@ -73,7 +72,6 @@ describe("Enter general partner's principal office manual address page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "usualResidentialAddress",
         "correspondenceAddress",
         "principalOfficeAddress",
diff --git a/src/presentation/test/integration/postTransition/generalPartner/address/enter-general-partner-usual-residential-address.test.ts b/src/presentation/test/integration/postTransition/generalPartner/address/enter-general-partner-usual-residential-address.test.ts
@@ -50,7 +50,6 @@ describe("Enter Usual Residential Address Page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "correspondenceAddress",
         "principalOfficeAddress",
         "postcodeOptional",
@@ -91,7 +90,6 @@ describe("Enter Usual Residential Address Page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "postcode",
         "correspondenceAddress",
         "principalOfficeAddress",
diff --git a/src/presentation/test/integration/postTransition/limitedPartner/address/enter-limited-partner-principal-office-address.test.ts b/src/presentation/test/integration/postTransition/limitedPartner/address/enter-limited-partner-principal-office-address.test.ts
@@ -44,7 +44,6 @@ describe("Enter limited partner's principal office manual address page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "usualResidentialAddress",
         "correspondenceAddress",
         "principalOfficeAddress",
@@ -73,7 +72,6 @@ describe("Enter limited partner's principal office manual address page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "usualResidentialAddress",
         "correspondenceAddress",
         "principalOfficeAddress",
diff --git a/src/presentation/test/integration/postTransition/limitedPartner/address/enter-limited-partner-usual-residential-address.test.ts b/src/presentation/test/integration/postTransition/limitedPartner/address/enter-limited-partner-usual-residential-address.test.ts
@@ -50,7 +50,6 @@ describe("Enter Usual Residential Address Page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "correspondenceAddress",
         "principalOfficeAddress",
         "postcodeOptional",
@@ -91,7 +90,6 @@ describe("Enter Usual Residential Address Page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "postcode",
         "correspondenceAddress",
         "principalOfficeAddress",
diff --git a/src/presentation/test/integration/registration/generalPartner/address/enter-general-partner-correspondence-address.test.ts b/src/presentation/test/integration/registration/generalPartner/address/enter-general-partner-correspondence-address.test.ts
@@ -57,7 +57,6 @@ describe("Enter Correspondence Address Page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "usualResidentialAddress",
         "principalOfficeAddress",
         "limitedPartner",
@@ -92,7 +91,6 @@ describe("Enter Correspondence Address Page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "postcode",
         "usualResidentialAddress",
         "limitedPartner",
diff --git a/src/presentation/test/integration/registration/generalPartner/address/enter-general-partner-principal-office-address.test.ts b/src/presentation/test/integration/registration/generalPartner/address/enter-general-partner-principal-office-address.test.ts
@@ -43,7 +43,6 @@ describe("Enter general partner's principal office manual address page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "usualResidentialAddress",
         "correspondenceAddress",
         "principalOfficeAddress",
@@ -72,7 +71,6 @@ describe("Enter general partner's principal office manual address page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "usualResidentialAddress",
         "correspondenceAddress",
         "principalOfficeAddress",
diff --git a/src/presentation/test/integration/registration/generalPartner/address/enter-general-partner-usual-residential-address.test.ts b/src/presentation/test/integration/registration/generalPartner/address/enter-general-partner-usual-residential-address.test.ts
@@ -50,7 +50,6 @@ describe("Enter Usual Residential Address Page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "correspondenceAddress",
         "principalOfficeAddress",
         "postcodeOptional",
@@ -91,7 +90,6 @@ describe("Enter Usual Residential Address Page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "postcode",
         "correspondenceAddress",
         "principalOfficeAddress",
diff --git a/src/presentation/test/integration/registration/limitedPartner/address/enter-limited-partner-principal-office-address.test.ts b/src/presentation/test/integration/registration/limitedPartner/address/enter-limited-partner-principal-office-address.test.ts
@@ -50,7 +50,6 @@ describe("Enter Limited Partner Principal Office Address Page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "postcodeOptional",
         "generalPartner",
         "usualResidentialAddress",
@@ -90,7 +89,6 @@ describe("Enter Limited Partner Principal Office Address Page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "postcode",
         "generalPartner",
         "usualResidentialAddress",
diff --git a/src/presentation/test/integration/registration/limitedPartner/address/enter-limited-partner-usual-residential-address.test.ts b/src/presentation/test/integration/registration/limitedPartner/address/enter-limited-partner-usual-residential-address.test.ts
@@ -50,7 +50,6 @@ describe("Enter Limited Partner Usual Residential Address Page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "postcodeOptional",
         "generalPartner",
         "principalOfficeAddress",
@@ -90,7 +89,6 @@ describe("Enter Limited Partner Usual Residential Address Page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "postcode",
         "generalPartner",
         "principalOfficeAddress",
diff --git a/src/presentation/test/integration/transition/generalPartner/address/enter-general-partner-correspondence-address.test.ts b/src/presentation/test/integration/transition/generalPartner/address/enter-general-partner-correspondence-address.test.ts
@@ -54,7 +54,6 @@ describe("Enter Correspondence Address Page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "usualResidentialAddress",
         "principalOfficeAddress",
         "limitedPartner",
@@ -89,7 +88,6 @@ describe("Enter Correspondence Address Page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "postcode",
         "usualResidentialAddress",
         "limitedPartner",
diff --git a/src/presentation/test/integration/transition/generalPartner/address/enter-general-partner-principal-office-address.test.ts b/src/presentation/test/integration/transition/generalPartner/address/enter-general-partner-principal-office-address.test.ts
@@ -43,7 +43,6 @@ describe("Enter general partner's principal office manual address page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "usualResidentialAddress",
         "correspondenceAddress",
         "principalOfficeAddress",
@@ -72,7 +71,6 @@ describe("Enter general partner's principal office manual address page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "usualResidentialAddress",
         "correspondenceAddress",
         "principalOfficeAddress",
diff --git a/src/presentation/test/integration/transition/generalPartner/address/enter-general-partner-usual-residential-address.test.ts b/src/presentation/test/integration/transition/generalPartner/address/enter-general-partner-usual-residential-address.test.ts
@@ -50,7 +50,6 @@ describe("Enter Usual Residential Address Page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "correspondenceAddress",
         "principalOfficeAddress",
         "postcodeOptional",
@@ -91,7 +90,6 @@ describe("Enter Usual Residential Address Page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "postcode",
         "correspondenceAddress",
         "principalOfficeAddress",
diff --git a/src/presentation/test/integration/transition/limitedPartner/address/enter-limited-partner-principal-office-address.test.ts b/src/presentation/test/integration/transition/limitedPartner/address/enter-limited-partner-principal-office-address.test.ts
@@ -50,7 +50,6 @@ describe("Enter Limited Partner Principal Office Address Page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "postcodeOptional",
         "generalPartner",
         "usualResidentialAddress",
@@ -90,7 +89,6 @@ describe("Enter Limited Partner Principal Office Address Page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "postcode",
         "generalPartner",
         "usualResidentialAddress",
diff --git a/src/presentation/test/integration/transition/limitedPartner/address/enter-limited-partner-usual-residential-address.test.ts b/src/presentation/test/integration/transition/limitedPartner/address/enter-limited-partner-usual-residential-address.test.ts
@@ -50,7 +50,6 @@ describe("Enter Limited Partner Usual Residential Address Page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "postcodeOptional",
         "generalPartner",
         "principalOfficeAddress",
@@ -90,7 +89,6 @@ describe("Enter Limited Partner Usual Residential Address Page", () => {
         "principalPlaceOfBusinessAddress",
         "jurisdictionCountry",
         "postcodeMissing",
-        "postcodeLength",
         "postcode",
         "generalPartner",
         "principalOfficeAddress",
diff --git a/src/views/enter-general-partner-correspondence-address.njk b/src/views/enter-general-partner-correspondence-address.njk
@@ -70,10 +70,7 @@
             classes: "govuk-input--width-10",
             id: "postal_code",
             name: "postal_code",
-            value: address.postal_code,
-            attributes: {
-              oninput: "validateLength(this, 15, '" + i18n.address.enterAddress.errorMessages.postcodeLength | escape + "');"
-            }
+            value: address.postal_code
           }) }}
 
           {% set countryFormId = "country" %}
diff --git a/src/views/enter-general-partner-principal-office-address.njk b/src/views/enter-general-partner-principal-office-address.njk
@@ -71,10 +71,7 @@
             classes: "govuk-input--width-10",
             id: "postal_code",
             name: "postal_code",
-            value: address.postal_code,
-            attributes: {
-              oninput: "validateLength(this, 15, '" + i18n.address.enterAddress.errorMessages.postcodeLength | escape + "');"
-            }
+            value: address.postal_code
           }) }}
 
           {% set countryFormId = "country" %}
diff --git a/src/views/enter-general-partner-usual-residential-address.njk b/src/views/enter-general-partner-usual-residential-address.njk
@@ -67,10 +67,7 @@
             classes: "govuk-input--width-10",
             id: "postal_code",
             name: "postal_code",
-            value: address.postal_code,
-            attributes: {
-              oninput: "validateLength(this, 15, '" + i18n.address.enterAddress.errorMessages.postcodeLength | escape + "');"
-            }
+            value: address.postal_code
           }) }}
 
           {% set countryFormId = "country" %}
diff --git a/src/views/enter-limited-partner-principal-office-address.njk b/src/views/enter-limited-partner-principal-office-address.njk
@@ -70,10 +70,7 @@
             classes: "govuk-input--width-10",
             id: "postal_code",
             name: "postal_code",
-            value: address.postal_code,
-            attributes: {
-              oninput: "validateLength(this, 15, '" + i18n.address.enterAddress.errorMessages.postcodeLength | escape + "');"
-            }
+            value: address.postal_code
           }) }}
 
           {% set countryFormId = "country" %}
diff --git a/src/views/enter-limited-partner-usual-residential-address.njk b/src/views/enter-limited-partner-usual-residential-address.njk
@@ -67,10 +67,7 @@
             classes: "govuk-input--width-10",
             id: "postal_code",
             name: "postal_code",
-            value: address.postal_code,
-            attributes: {
-              oninput: "validateLength(this, 15, '" + i18n.address.enterAddress.errorMessages.postcodeLength | escape + "');"
-            }
+            value: address.postal_code
           }) }}
 
           {% set countryFormId = "country" %}
diff --git a/src/views/pages/address/postcode-form.njk b/src/views/pages/address/postcode-form.njk
@@ -24,8 +24,7 @@
             classes: "govuk-input--width-10",
             value: props.data.postal_code,
             attributes: {
-              required: true,
-              pattern: "^[A-Za-z]{1,2}\\d[A-Za-z\\d]? ?\\d[A-Za-z]{2}$"
+              required: true
             }
         }) }}
        
