Merge pull request #590 from companieshouse/lp-1324-designate-pflp-description

LP-1324 - Redesignate update details

Author: mattch1

src/config/constants.ts

@@ -52,6 +52,7 @@ export const TRANSACTION_DESCRIPTION_REMOVE_GENERAL_PARTNER_PERSON = "Remove a g
 export const TRANSACTION_DESCRIPTION_REMOVE_GENERAL_PARTNER_LEGAL_ENTITY = "Remove a general partner (legal entity)";
 export const TRANSACTION_DESCRIPTION_REMOVE_LIMITED_PARTNER_PERSON = "Remove a limited partner (person)";
 export const TRANSACTION_DESCRIPTION_REMOVE_LIMITED_PARTNER_LEGAL_ENTITY = "Remove a limited partner (legal entity)";
+export const TRANSACTION_DESCRIPTION_DESIGNATE_AS_PRIVATE_FUND_PARTNERSHIP = "Designate as a private fund limited partnership";
 
 // Templates
 export const ERROR_TEMPLATE = "error-page";

src/presentation/controller/postTransition/LimitedPartnershipController.ts

@@ -20,7 +20,8 @@ import {
   CHANGE_CHECK_YOUR_ANSWERS_TYPE_SUFFIX,
   CHANGE_CHECK_YOUR_ANSWERS_TEMPLATE,
   TRANSACTION_DESCRIPTION_UPDATE_LIMITED_PARTNERSHIP,
-  CHS_URL
+  CHS_URL,
+  TRANSACTION_DESCRIPTION_DESIGNATE_AS_PRIVATE_FUND_PARTNERSHIP
 } from "../../../config/constants";
 import { formatDate } from "../../../utils/date-format";
 import { getJourneyTypes } from "../../../utils";
@@ -231,7 +232,8 @@ class LimitedPartnershipController extends AbstractController {
           }
         }
 
-        const resultTransaction = await this.createTransaction(limitedPartnership, tokens);
+        const resultTransaction = await this.createTransaction(
+          limitedPartnership, tokens, TRANSACTION_DESCRIPTION_UPDATE_LIMITED_PARTNERSHIP);
         if (resultTransaction.errors) {
           return response.render(
             super.templateName(pageRouting.currentUrl),
@@ -440,7 +442,8 @@ class LimitedPartnershipController extends AbstractController {
           request.body
         );
 
-        const resultTransaction = await this.createTransaction(limitedPartnership, tokens);
+        const resultTransaction = await this.createTransaction(
+          limitedPartnership, tokens, TRANSACTION_DESCRIPTION_DESIGNATE_AS_PRIVATE_FUND_PARTNERSHIP);
         if (resultTransaction.errors) {
           return response.render(
             super.templateName(pageRouting.currentUrl),
@@ -572,15 +575,15 @@ class LimitedPartnershipController extends AbstractController {
     }
   }
 
-  private async createTransaction(limitedPartnership: LimitedPartnership, tokens: Tokens) {
+  private async createTransaction(limitedPartnership: LimitedPartnership, tokens: Tokens, description: string) {
     const resultTransaction = await this.transactionService.createTransaction(
       tokens,
       IncorporationKind.POST_TRANSITION,
       {
         companyName: limitedPartnership?.data?.partnership_name ?? "",
         companyNumber: limitedPartnership?.data?.partnership_number ?? ""
       },
-      TRANSACTION_DESCRIPTION_UPDATE_LIMITED_PARTNERSHIP
+      description
     );
 
     return resultTransaction;

src/presentation/test/integration/postTransition/limitedPartnership/redesignate-to-pflp.test.ts

@@ -10,7 +10,7 @@ import { REDESIGNATE_TO_PFLP_URL } from "presentation/controller/postTransition/
 import CompanyProfileBuilder from "../../../builder/CompanyProfileBuilder";
 import PostTransitionPageType from "presentation/controller/postTransition/pageType";
 import { PartnershipType } from "@companieshouse/api-sdk-node/dist/services/limited-partnerships";
-import { TRANSACTION_DESCRIPTION_UPDATE_LIMITED_PARTNERSHIP } from "config";
+import { TRANSACTION_DESCRIPTION_DESIGNATE_AS_PRIVATE_FUND_PARTNERSHIP } from "config";
 import LimitedPartnershipBuilder from "presentation/test/builder/LimitedPartnershipBuilder";
 import { ApiErrors } from "domain/entities/UIErrors";
 
@@ -52,7 +52,7 @@ describe("Redesignate to pflp page", () => {
   });
 
   describe("POST page", () => {
-    it("should create a transaction, send data and navigate to payment", async () => {
+    it("should create a transaction for designate to private funds, send data and navigate to payment", async () => {
       const res = await request(app).post(URL).send({
         pageType: PostTransitionPageType.redesignateToPflp,
         redesignate_to_pflp_apply: true,
@@ -63,7 +63,7 @@ describe("Redesignate to pflp page", () => {
       expect(res.status).toBe(302);
       expect(res.text).toContain(`Redirecting to ${PAYMENT_LINK_JOURNEY}`);
       expect(appDevDependencies.limitedPartnershipGateway.limitedPartnerships.length).toEqual(1);
-      expect(appDevDependencies.transactionGateway.transactions[0].description).toEqual(TRANSACTION_DESCRIPTION_UPDATE_LIMITED_PARTNERSHIP);
+      expect(appDevDependencies.transactionGateway.transactions[0].description).toEqual(TRANSACTION_DESCRIPTION_DESIGNATE_AS_PRIVATE_FUND_PARTNERSHIP);
     });
 
     it("should return a validation error if api validation error occurs creating LimitedPartnership", async () => {

src/views/redesignate-to-pflp.njk

@@ -28,7 +28,7 @@
           <li> {{ i18n.redesignateToPflpPage.pflpMeanings.admin }} </li>
           <li> {{ i18n.redesignateToPflpPage.pflpMeanings.scheme }} </li>
         </ul>
-        <p class="govuk-body"> {{ i18n.redesignateToPflpPage.information }} <a href="https://www.legislation.gov.uk/uksi/2017/514/article/2/made" class="govuk-link">{{ i18n.redesignateToPflpPage.informationLink }}</a>.</p>
+        <p class="govuk-body"> {{ i18n.redesignateToPflpPage.information }} <a href="https://www.legislation.gov.uk/uksi/2017/514/article/2/made" target="_blank" class="govuk-link">{{ i18n.redesignateToPflpPage.informationLink }}</a>.</p>
         <p class="govuk-body">{{ i18n.redesignateToPflpPage.cost }}</p>      
 
         {{ govukCheckboxes({