pr comment - using StringUtils.isBlank() to check if variable is null or empty

Author: nabeelamirch

src/main/java/uk/gov/companieshouse/orders/api/validator/DeliveryDetailsValidator.java

@@ -1,5 +1,6 @@
 package uk.gov.companieshouse.orders.api.validator;
 
+import org.apache.commons.lang.StringUtils;
 import org.springframework.stereotype.Component;
 import uk.gov.companieshouse.orders.api.dto.AddDeliveryDetailsRequestDTO;
 
@@ -17,8 +18,8 @@ public List<String> getValidationErrors(final AddDeliveryDetailsRequestDTO addDe
         String postalCode = addDeliveryDetailsRequestDTO.getDeliveryDetails().getPostalCode();
         String region = addDeliveryDetailsRequestDTO.getDeliveryDetails().getRegion();
 
-        if((postalCode == null || postalCode.isEmpty()) && (region==null || region.isEmpty())) {
-            errors.add("Post code or Region is required");
+        if(StringUtils.isBlank(postalCode) && StringUtils.isBlank(region)) {
+            errors.add("Postcode or Region is required");
         }
 
         return errors;

src/test/java/uk/gov/companieshouse/orders/api/validator/DeliveryDetailsValidatorTest.java

@@ -48,6 +48,6 @@ void postcodeOrRegionIsMandatory() {
 
         final List<String> errors = deliveryDetailsValidator.getValidationErrors(dto);
 
-        assertThat(errors, contains("Post code or Region is required"));
+        assertThat(errors, contains("Postcode or Region is required"));
     }
 }