Skip to content

Commit 79a7cb2

Browse files
authored
Merge pull request #196 from companieshouse/feature/rollover-dependency-check
Updated Makefile for dependency
2 parents 2efa009 + 3e30edb commit 79a7cb2

File tree

2 files changed

+2
-32
lines changed

2 files changed

+2
-32
lines changed

Makefile

Lines changed: 1 addition & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -65,31 +65,4 @@ sonar:
6565

6666
.PHONY: sonar-pr-analysis
6767
sonar-pr-analysis:
68-
mvn sonar:sonar -P sonar-pr-analysis
69-
70-
.PHONY: dependency-check
71-
dependency-check:
72-
@ if [ -n "$(DEPENDENCY_CHECK_SUPPRESSIONS_HOME)" ]; then \
73-
if [ -d "$(DEPENDENCY_CHECK_SUPPRESSIONS_HOME)" ]; then \
74-
suppressions_home="$${DEPENDENCY_CHECK_SUPPRESSIONS_HOME}"; \
75-
else \
76-
printf -- 'DEPENDENCY_CHECK_SUPPRESSIONS_HOME is set, but its value "%s" does not point to a directory\n' "$(DEPENDENCY_CHECK_SUPPRESSIONS_HOME)"; \
77-
exit 1; \
78-
fi; \
79-
fi; \
80-
if [ ! -d "$${suppressions_home}" ]; then \
81-
suppressions_home_target_dir="./target/dependency-check-suppressions"; \
82-
if [ -d "$${suppressions_home_target_dir}" ]; then \
83-
suppressions_home="$${suppressions_home_target_dir}"; \
84-
else \
85-
mkdir -p "./target"; \
86-
git clone [email protected]:companieshouse/dependency-check-suppressions.git "$${suppressions_home_target_dir}" && \
87-
suppressions_home="$${suppressions_home_target_dir}"; \
88-
fi; \
89-
fi; \
90-
printf -- 'suppressions_home="%s"\n' "$${suppressions_home}"; \
91-
DEPENDENCY_CHECK_SUPPRESSIONS_HOME="$${suppressions_home}" "$${suppressions_home}/scripts/depcheck" --repo-name=orders.api.ch.gov.uk
92-
93-
.PHONY: security-check
94-
security-check: dependency-check
95-
68+
mvn sonar:sonar -P sonar-pr-analysis

pom.xml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<parent>
77
<groupId>uk.gov.companieshouse</groupId>
88
<artifactId>companies-house-parent</artifactId>
9-
<version>2.1.11</version>
9+
<version>2.1.12</version>
1010
<relativePath/>
1111
</parent>
1212
<artifactId>orders.api.ch.gov.uk</artifactId>
@@ -59,9 +59,6 @@
5959
${project.basedir}/target/site/jacoco-it/jacoco.xml
6060
</sonar.coverage.jacoco.xmlReportPaths>
6161
<sonar.jacoco.reports>${project.basedir}/target/site</sonar.jacoco.reports>
62-
<sonar.dependencyCheck.htmlReportPath>
63-
${project.basedir}/target/dependency-check-report.html
64-
</sonar.dependencyCheck.htmlReportPath>
6562
<sonar.java.binaries>
6663
${project.basedir}/target
6764
</sonar.java.binaries>

0 commit comments

Comments
 (0)