Merge pull request #185 from companieshouse/bi-12452-update-checkout-status-fix

BI-12452 - Update checkout status for free orders

Author: rmcmurray-ch

src/main/java/uk/gov/companieshouse/orders/api/controller/BasketController.java

@@ -424,7 +424,6 @@ public ResponseEntity<?> checkoutBasket(@RequestBody(required = false) String js
             LOGGER.infoRequest(request, "Basket checkout completed no payment required", logMap);
             checkoutData.setPaymentReference("FREEINTERNALORDER");
 
-            checkoutData.setStatus(PaymentStatus.FREE);
             processOrder(checkout, logMap);
             LOGGER.infoRequest(request, "Free order processed", logMap);
             return new ResponseEntity<>(checkoutData, OK);
@@ -504,6 +503,7 @@ public ResponseEntity<String> patchBasketPaymentDetails(@NonNull final @RequestB
         } else {
 
             // Update the checkout of non-paid order
+            checkoutData.setStatus(PaymentStatus.FREE);
             updateCheckout(checkout, basketPaymentRequestDTO);
             LOGGER.infoRequest(request, "Checkout updated for order not requiring any payment", logMap);
         }