Skip to content

Commit a613789

Browse files
Merge pull request #190 from companieshouse/feature/use-dep-check-suppressions-main
use latest dependency-check setup
2 parents 51bcfc1 + 8102ed6 commit a613789

File tree

2 files changed

+6
-11
lines changed

2 files changed

+6
-11
lines changed

Makefile

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,7 @@ artifact_name := orders.api.ch.gov.uk
22
version := "unversioned"
33

44
dependency_check_base_suppressions:=common_suppressions_spring_6.xml
5-
6-
# dependency_check_suppressions_repo_branch
7-
# The branch of the dependency-check-suppressions repository to use
8-
# as the source of the suppressions file.
9-
# This should point to "main" branch when being used for release,
10-
# but can point to a different branch for experimentation/development.
11-
dependency_check_suppressions_repo_branch:=feature/suppressions-for-company-accounts-api
12-
5+
dependency_check_suppressions_repo_branch:=main
136
dependency_check_minimum_cvss := 4
147
dependency_check_assembly_analyzer_enabled := false
158
dependency_check_suppressions_repo_url:[email protected]:companieshouse/dependency-check-suppressions.git
@@ -105,11 +98,12 @@ dependency-check:
10598
suppressions_path="$${suppressions_home}/suppressions/$(dependency_check_base_suppressions)"; \
10699
if [ -f "$${suppressions_path}" ]; then \
107100
cp -av "$${suppressions_path}" $(suppressions_file); \
108-
mvn org.owasp:dependency-check-maven:check -DfailBuildOnCVSS=$(dependency_check_minimum_cvss) -DassemblyAnalyzerEnabled=$(dependency_check_assembly_analyzer_enabled) -DsuppressionFiles=$(suppressions_file); \
101+
mvn org.owasp:dependency-check-maven:check -Dformats="json,html" -DprettyPrint -DfailBuildOnCVSS=$(dependency_check_minimum_cvss) -DassemblyAnalyzerEnabled=$(dependency_check_assembly_analyzer_enabled) -DsuppressionFiles=$(suppressions_file); \
109102
else \
110103
printf -- "\n ERROR Cannot find suppressions file at '%s'\n" "$${suppressions_path}" >&2; \
111104
exit 1; \
112105
fi
113106

114107
.PHONY: security-check
115-
security-check: dependency-check
108+
security-check: dependency-check
109+

pom.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
<parent>
77
<groupId>uk.gov.companieshouse</groupId>
88
<artifactId>companies-house-parent</artifactId>
9-
<version>2.1.6</version>
9+
<version>2.1.11</version>
10+
<relativePath/>
1011
</parent>
1112
<artifactId>orders.api.ch.gov.uk</artifactId>
1213
<version>unversioned</version>

0 commit comments

Comments
 (0)