pr comment - renamed service

Author: nabeelamirch

src/main/java/uk/gov/companieshouse/orders/api/controller/BasketController.java

@@ -49,10 +49,10 @@ public ResponseEntity<AddToBasketResponseDTO> addItemToBasket(final @Valid @Requ
         Basket returnedBasket;
         if(retrievedBasket.isPresent()) {
             retrievedBasket.get().getData().setItems(mappedBasket.getData().getItems());
-            returnedBasket = basketService.saveBasketItem(retrievedBasket.get());
+            returnedBasket = basketService.saveBasket(retrievedBasket.get());
         } else {
             mappedBasket.setId(EricHeaderHelper.getIdentity(request));
-            returnedBasket = basketService.saveBasketItem(mappedBasket);
+            returnedBasket = basketService.saveBasket(mappedBasket);
         }
 
         final AddToBasketResponseDTO basketItemDTO = mapper.basketToAddToBasketDTO(returnedBasket);

src/main/java/uk/gov/companieshouse/orders/api/service/BasketService.java

@@ -16,7 +16,7 @@ public BasketService(BasketRepository repository) {
         this.repository = repository;
     }
 
-    public Basket saveBasketItem(Basket basket) {
+    public Basket saveBasket(Basket basket) {
         final LocalDateTime now = LocalDateTime.now();
         if(basket.getId() == null) {
             throw new IllegalArgumentException("ID Must be present");

src/test/java/uk/gov/companieshouse/orders/api/service/BasketServiceTest.java

@@ -34,7 +34,7 @@ public void saveBasketItemPopulatesCreatedAtAndUpdatedAtAndSavesItem() {
 
         final LocalDateTime intervalStart = LocalDateTime.now();
 
-        service.saveBasketItem(basket);
+        service.saveBasket(basket);
 
         final LocalDateTime intervalEnd = LocalDateTime.now();
         assertThat(basket.getCreatedAt().isAfter(intervalStart) ||
@@ -56,7 +56,7 @@ public void saveBasketItemPopulatesUpdatedAtAndSavesItem() {
 
         final LocalDateTime intervalStart = LocalDateTime.now();
 
-        service.saveBasketItem(basket);
+        service.saveBasket(basket);
 
         final LocalDateTime intervalEnd = LocalDateTime.now();
         assertThat(basket.getCreatedAt(), is(CREATED_AT));
@@ -71,7 +71,7 @@ public void saveBasketItemPopulatesUpdatedAtAndSavesItem() {
     public void createBasketThrowsExceptionIfIdNotPresent() {
         assertThrows(IllegalArgumentException.class, () -> {
             final Basket basket = new Basket();
-            service.saveBasketItem(basket);
+            service.saveBasket(basket);
         });
     }