Merge pull request #1702 from companieshouse/ROECCT-514-CHANGE-ERROR-MESSAGE-OEID-INVALID

ROECCT-514: Remove personal information shown in Overseas Entity ID validation message

Author: jnicholson-ch

src/controllers/update/overseas.entity.query.controller.ts

@@ -70,16 +70,16 @@ export const post = async (req: Request, res: Response, next: NextFunction) => {
   }
 };
 
-function createEntityNumberError(entityNumber: string): any {
-  const msg = `An Overseas Entity with OE number "${entityNumber}" was not found.`;
+function createEntityNumberError(): any {
+  const msg = `Enter a correct Overseas Entity ID.`;
   const errors = { errorList: [] } as any;
   errors.errorList.push({ href: "#entity_number", text: msg });
   errors.entity_number = { text: msg };
   return errors;
 }
 
 const renderGetPageWithError = async (req: Request, res: Response, entityNumber: any) => {
-  const errors = createEntityNumberError(entityNumber);
+  const errors = createEntityNumberError();
   const isRemove: boolean = await isRemoveJourney(req);
 
   if (isRemove) {

test/controllers/update/overseas.entity.query.controller.spec.ts

@@ -35,7 +35,7 @@ import { ApplicationData } from "../../../src/model";
 
 const testOENumber = "OE123456";
 const invalidOENUmberError = "OE number must be "OE" followed by 6 digits";
-const notFoundOENumberError = "An Overseas Entity with OE number "" + testOENumber + "" was not found";
+const notFoundOENumberError = "Enter a correct Overseas Entity ID";
 
 mockJourneyDetectionMiddleware.mockClear();
 mockCsrfProtectionMiddleware.mockClear();