Skip to content

Commit 45463ce

Browse files
authored
Merge pull request #180 from companieshouse/feature/check-for-internal-id
Add null check for internal-id in psc-data when doing full_record call
2 parents 8cc3c82 + b1762ed commit 45463ce

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

src/main/java/uk/gov/companieshouse/pscdataapi/service/CompanyPscService.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -212,9 +212,13 @@ public PscIndividualFullRecordApi getIndividualFullRecord(final String companyNu
212212
}
213213

214214
if (featureFlags.isIndividualPscFullRecordAddVerificationStateEnabled()) {
215-
oracleQueryApiService.getPscVerificationState(individualFullRecord.getInternalId())
216-
.map(verificationStateMapper::mapToVerificationState)
217-
.ifPresent(individualFullRecord::setVerificationState);
215+
if (individualFullRecord.getInternalId() != null) {
216+
oracleQueryApiService.getPscVerificationState(individualFullRecord.getInternalId())
217+
.map(verificationStateMapper::mapToVerificationState)
218+
.ifPresent(individualFullRecord::setVerificationState);
219+
} else {
220+
logger.error("Internal ID not found in PSC document.", DataMapHolder.getLogMap());
221+
}
218222
}
219223
return individualFullRecord;
220224

0 commit comments

Comments
 (0)