fix(win): transparent label

Author: Berrysoft

src/runtime/windows.rs

@@ -19,8 +19,7 @@ use windows_sys::{
         Foundation::{COLORREF, HANDLE, HWND, LPARAM, LRESULT, POINT, RECT, WAIT_FAILED, WPARAM},
         Graphics::Gdi::{
             BLACK_BRUSH, CreateSolidBrush, GetStockObject, HDC, InvalidateRect, Rectangle,
-            ScreenToClient, SelectObject, SetBkColor, SetBkMode, SetTextColor, TRANSPARENT,
-            WHITE_BRUSH,
+            ScreenToClient, SelectObject, SetBkColor, SetTextColor, WHITE_BRUSH,
         },
         System::Threading::INFINITE,
         UI::{
@@ -42,7 +41,8 @@ use windows_sys::{
 use super::RUNTIME;
 use crate::ui::{
     darkmode::{
-        children_refresh_dark_mode, init_dark, is_dark_mode_allowed_for_app, window_use_dark_mode,
+        children_refresh_dark_mode, control_color_static, init_dark, is_dark_mode_allowed_for_app,
+        window_use_dark_mode,
     },
     dpi::get_dpi_for_window,
     font::{WinBrush, default_font},
@@ -296,18 +296,7 @@ pub(crate) unsafe extern "system" fn window_proc(
                 InvalidateRect(handle, null(), 1);
             }
             WM_CTLCOLORSTATIC => {
-                let dark = is_dark_mode_allowed_for_app();
-                let hdc = wparam as HDC;
-                SetBkMode(hdc, TRANSPARENT as _);
-                if dark {
-                    SetTextColor(hdc, WHITE);
-                    SetBkColor(hdc, BLACK);
-                }
-                return if dark {
-                    GetStockObject(BLACK_BRUSH)
-                } else {
-                    GetStockObject(WHITE_BRUSH)
-                } as _;
+                return control_color_static(lparam as HWND, wparam as HDC);
             }
             WM_CTLCOLORBTN => {
                 if is_dark_mode_allowed_for_app() {

src/ui/windows/darkmode/hook.rs

@@ -10,7 +10,6 @@ use widestring::U16CStr;
 use windows_sys::{
     Win32::{
         Foundation::{COLORREF, HWND, LPARAM, LRESULT, RECT, S_OK, WPARAM},
-        Globalization::{CSTR_EQUAL, CompareStringW, LOCALE_ALL, NORM_IGNORECASE},
         Graphics::{
             Dwm::DwmSetWindowAttribute,
             Gdi::{
@@ -40,7 +39,10 @@ use windows_sys::{
     w,
 };
 
-use crate::ui::{darkmode::PreferredAppMode, font::WinBrush};
+use crate::ui::{
+    darkmode::{PreferredAppMode, WHITE, u16_string_eq_ignore_case},
+    font::WinBrush,
+};
 
 #[link(name = "ntdll")]
 extern "system" {
@@ -240,8 +242,6 @@ unsafe extern "system" fn dark_draw_theme_text(
     dwtextflags2: u32,
     prect: *const RECT,
 ) -> HRESULT {
-    const WHITE: COLORREF = 0x00FFFFFF;
-
     if is_dark_mode_allowed_for_app()
         && (ipartid == BP_CHECKBOX || ipartid == BP_RADIOBUTTON)
         && istateid != PBS_DISABLED
@@ -370,20 +370,6 @@ pub unsafe fn children_refresh_dark_mode(handle: HWND, lparam: LPARAM) {
     EnumChildWindows(handle, Some(enum_callback), lparam);
 }
 
-#[inline]
-fn u16_string_eq_ignore_case(s1: &U16CStr, s2: *const u16) -> bool {
-    unsafe {
-        CompareStringW(
-            LOCALE_ALL,
-            NORM_IGNORECASE,
-            s1.as_ptr(),
-            s1.len() as _,
-            s2,
-            -1,
-        ) == CSTR_EQUAL
-    }
-}
-
 pub unsafe fn control_use_dark_mode(hwnd: HWND, misc_task_dialog: bool) {
     let mut class = [0u16; MAX_CLASS_NAME as usize];
     GetClassNameW(hwnd, class.as_mut_ptr(), MAX_CLASS_NAME);

src/ui/windows/darkmode/mod.rs

@@ -1,3 +1,15 @@
+use widestring::U16CStr;
+use windows_sys::Win32::{
+    Foundation::{COLORREF, HWND, LRESULT},
+    Globalization::{CSTR_EQUAL, CompareStringW, LOCALE_ALL, NORM_IGNORECASE},
+    Graphics::Gdi::{
+        BLACK_BRUSH, GetStockObject, HDC, NULL_BRUSH, SetBkColor, SetBkMode, SetTextColor,
+        TRANSPARENT, WHITE_BRUSH,
+    },
+    System::SystemServices::MAX_CLASS_NAME,
+    UI::{Controls::WC_STATICW, WindowsAndMessaging::GetClassNameW},
+};
+
 cfg_if::cfg_if! {
     if #[cfg(feature = "windows-dark-mode")] {
         #[path = "hook.rs"]
@@ -19,3 +31,45 @@ pub enum PreferredAppMode {
     ForceDark  = 2,
     ForceLight = 3,
 }
+
+#[inline]
+fn u16_string_eq_ignore_case(s1: &U16CStr, s2: *const u16) -> bool {
+    unsafe {
+        CompareStringW(
+            LOCALE_ALL,
+            NORM_IGNORECASE,
+            s1.as_ptr(),
+            s1.len() as _,
+            s2,
+            -1,
+        ) == CSTR_EQUAL
+    }
+}
+
+const WHITE: COLORREF = 0x00FFFFFF;
+const BLACK: COLORREF = 0x00000000;
+
+pub unsafe fn control_color_static(hwnd: HWND, hdc: HDC) -> LRESULT {
+    let dark = is_dark_mode_allowed_for_app();
+
+    let mut class = [0u16; MAX_CLASS_NAME as usize];
+    GetClassNameW(hwnd, class.as_mut_ptr(), MAX_CLASS_NAME);
+    let class = U16CStr::from_ptr_str(class.as_ptr());
+    let is_static = u16_string_eq_ignore_case(class, WC_STATICW);
+
+    SetBkMode(hdc, TRANSPARENT as _);
+    if dark {
+        SetTextColor(hdc, WHITE);
+        if !is_static {
+            SetBkColor(hdc, BLACK);
+        }
+    }
+    let res = if is_static {
+        GetStockObject(NULL_BRUSH)
+    } else if dark {
+        GetStockObject(BLACK_BRUSH)
+    } else {
+        GetStockObject(WHITE_BRUSH)
+    };
+    res as _
+}

src/ui/windows/label.rs

@@ -5,7 +5,7 @@ use windows_sys::Win32::{
     System::SystemServices::{SS_CENTER, SS_LEFT, SS_RIGHT},
     UI::{
         Controls::WC_STATICW,
-        WindowsAndMessaging::{WS_CHILD, WS_VISIBLE},
+        WindowsAndMessaging::{WS_CHILD, WS_EX_TRANSPARENT, WS_VISIBLE},
     },
 };
 
@@ -24,7 +24,7 @@ impl Label {
         let mut handle = Widget::new(
             WC_STATICW,
             WS_CHILD | WS_VISIBLE | SS_LEFT,
-            0,
+            WS_EX_TRANSPARENT,
             parent.as_window().as_raw_window(),
         );
         handle.set_size(handle.size_d2l((100, 50)));