fix(win32): non-transparent LinkLabel bk color

Author: Chaoses-Ib

winio-ui-win32/src/runtime.rs

@@ -21,10 +21,7 @@ use windows_sys::{
         Foundation::{HWND, LPARAM, LRESULT, RECT, SetLastError, WPARAM},
         Graphics::{
             Dwm::DwmExtendFrameIntoClientArea,
-            Gdi::{
-                BLACK_BRUSH, GetStockObject, HDC, InvalidateRect, NULL_BRUSH, SetBkMode,
-                SetTextColor, TRANSPARENT, WHITE_BRUSH,
-            },
+            Gdi::{BLACK_BRUSH, GetStockObject, HDC, InvalidateRect, WHITE_BRUSH},
         },
         UI::{
             Controls::{MARGINS, NMHDR},
@@ -41,8 +38,8 @@ use windows_sys::{
     core::BOOL,
 };
 use winio_ui_windows_common::{
-    Backdrop, children_refresh_dark_mode, control_color_edit, control_color_static, init_dark,
-    is_dark_mode_allowed_for_app, window_use_dark_mode,
+    Backdrop, children_refresh_dark_mode, control_color_edit, control_color_link_label,
+    control_color_static, init_dark, is_dark_mode_allowed_for_app, window_use_dark_mode,
 };
 
 use super::RUNTIME;
@@ -289,13 +286,7 @@ pub(crate) unsafe extern "system" fn window_proc(
             let mut data = 0;
             if GetWindowSubclass(hwnd, Some(link_label_wnd_proc), 0, &mut data) != 0 {
                 // This is a LinkLabel
-                SetBkMode(hdc, TRANSPARENT as _);
-                if is_dark_mode_allowed_for_app() {
-                    SetTextColor(hdc, 0xFFFC96);
-                } else {
-                    SetTextColor(hdc, 0xCC6600);
-                }
-                return GetStockObject(NULL_BRUSH) as _;
+                return control_color_link_label(hwnd, hdc);
             } else {
                 return control_color_static(hwnd, hdc);
             }

winio-ui-windows-common/src/darkmode/mod.rs

@@ -116,6 +116,35 @@ pub unsafe fn control_color_static(hwnd: HWND, hdc: HDC) -> LRESULT {
     }
 }
 
+/// # Safety
+/// It should only be called inside an wndproc, and `hwnd` & `hdc` should be
+/// valid.
+pub unsafe fn control_color_link_label(hwnd: HWND, hdc: HDC) -> LRESULT {
+    unsafe {
+        let dark = is_dark_mode_allowed_for_app();
+
+        let is_transparent = (GetWindowLongPtrW(hwnd, GWL_EXSTYLE) as u32 & WS_EX_TRANSPARENT) != 0;
+
+        SetBkMode(hdc, TRANSPARENT as _);
+        if dark {
+            SetTextColor(hdc, 0xFFFC96);
+            if !is_transparent {
+                SetBkColor(hdc, BLACK);
+            }
+        } else {
+            SetTextColor(hdc, 0xCC6600);
+        }
+        let res = if is_transparent {
+            GetStockObject(NULL_BRUSH)
+        } else if dark {
+            GetStockObject(BLACK_BRUSH)
+        } else {
+            GetStockObject(WHITE_BRUSH)
+        };
+        res as _
+    }
+}
+
 /// # Safety
 /// It should only be called inside an wndproc, and `hparent` & `hwnd` & `hdc`
 /// should be valid.