Skip to content

Commit ab6bd09

Browse files
committed
fix: check error returns in cleanup_test.go
1 parent 43c5d03 commit ab6bd09

1 file changed

Lines changed: 21 additions & 7 deletions

File tree

cmd/sync-content/cleanup_test.go

Lines changed: 21 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,12 @@ func TestCleanOrphanedFiles(t *testing.T) {
1515
otherFile := filepath.Join(dir, "content", "docs", "projects", "complyscribe", "_index.md")
1616

1717
for _, f := range []string{staleFile, keptFile, otherFile} {
18-
os.MkdirAll(filepath.Dir(f), 0o755)
19-
os.WriteFile(f, []byte("test"), 0o644)
18+
if err := os.MkdirAll(filepath.Dir(f), 0o755); err != nil {
19+
t.Fatalf("MkdirAll(%s): %v", filepath.Dir(f), err)
20+
}
21+
if err := os.WriteFile(f, []byte("test"), 0o644); err != nil {
22+
t.Fatalf("WriteFile(%s): %v", f, err)
23+
}
2024
}
2125

2226
oldManifest := map[string]bool{
@@ -51,8 +55,12 @@ func TestCleanOrphanedFiles_PrunesEmptyDirs(t *testing.T) {
5155

5256
staleDir := filepath.Join(dir, "content", "docs", "projects", "removed-repo")
5357
staleFile := filepath.Join(staleDir, "_index.md")
54-
os.MkdirAll(staleDir, 0o755)
55-
os.WriteFile(staleFile, []byte("test"), 0o644)
58+
if err := os.MkdirAll(staleDir, 0o755); err != nil {
59+
t.Fatalf("MkdirAll: %v", err)
60+
}
61+
if err := os.WriteFile(staleFile, []byte("test"), 0o644); err != nil {
62+
t.Fatalf("WriteFile: %v", err)
63+
}
5664

5765
oldManifest := map[string]bool{
5866
"content/docs/projects/removed-repo/_index.md": true,
@@ -73,7 +81,9 @@ func TestCleanOrphanedFiles_TraversalBlocked(t *testing.T) {
7381

7482
outsideDir := t.TempDir()
7583
outsideFile := filepath.Join(outsideDir, "should-survive.txt")
76-
os.WriteFile(outsideFile, []byte("protected"), 0o644)
84+
if err := os.WriteFile(outsideFile, []byte("protected"), 0o644); err != nil {
85+
t.Fatalf("WriteFile: %v", err)
86+
}
7787

7888
relTraversal, err := filepath.Rel(dir, outsideFile)
7989
if err != nil {
@@ -98,8 +108,12 @@ func TestCleanOrphanedFiles_LegitimateRemoval(t *testing.T) {
98108
dir := t.TempDir()
99109

100110
legitFile := filepath.Join(dir, "content", "docs", "projects", "old-repo", "_index.md")
101-
os.MkdirAll(filepath.Dir(legitFile), 0o755)
102-
os.WriteFile(legitFile, []byte("stale"), 0o644)
111+
if err := os.MkdirAll(filepath.Dir(legitFile), 0o755); err != nil {
112+
t.Fatalf("MkdirAll: %v", err)
113+
}
114+
if err := os.WriteFile(legitFile, []byte("stale"), 0o644); err != nil {
115+
t.Fatalf("WriteFile: %v", err)
116+
}
103117

104118
oldManifest := map[string]bool{
105119
"content/docs/projects/old-repo/_index.md": true,

0 commit comments

Comments
 (0)