NF: added ability to pass strings as event attrs; #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BF: updated pywt 'per' parameter; BF: removed unused wica parameters;
Contributor
|
Thanks for the PR! Can you explain why you're making the change to remove_strong_artifacts? |
Author
|
It unifies wica.WICA.clean() and wica.wica_clean(), which relied on different parameterizations of remove_strong_artifacts. The first two parameters of remove_strong_artifacts were just ignored anyway (and aren't included in the remove_strong_artifacts docstring), so I removed them to unify the cleaning functions and to make the parameterization clearer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BF: updated pywt 'per' parameter (pywt upstream change);
BF: removed unused wica parameters;