Using tool tip crashes application on compose 1.11.0-alpha05

[ddrb56]

Describe your issue

Due to compose foundation removing the isDetectTapGesturesImmediateCoroutineDispatchEnabled flag on the latest version, the app crashes with the following exception:

java.lang.NoSuchFieldError: No static field isDetectTapGesturesImmediateCoroutineDispatchEnabled of type Z in class Landroidx/compose/foundation/ComposeFoundationFlags; or its superclasses (declaration of 'androidx.compose.foundation.ComposeFoundationFlags' appears in /data/app/~~Q0uS42EVvx4kECKHJHEIpA==/io.ggs.waypoint.debug-ax-ccbEuw9MU0eXurzBvWA==/base.apk)
                                                                                                    	at core.com.composeunstyled.LongClickableKt.getCoroutineStartForCurrentDispatchBehavior(LongClickable.kt:74)
                                                                                                    	at core.com.composeunstyled.LongClickableKt.access$getCoroutineStartForCurrentDispatchBehavior(LongClickable.kt:1)
                                                                                                    	at core.com.composeunstyled.LongClickableKt$detectTapGestures$2$1.invokeSuspend(LongClickable.kt:147)

What version of Compose Unstyled are you using?

1.49.6

What version of Compose are you using?

1.11.0-alpha05

Which platforms can you reproduce the bug on?

Select one or multiple:

• Android
• iOS
• Desktop (Windows, Linux, MacOS)
• Web WASM
• Web JS

Minimum reproducible code

Any code that uses the tool tip composable

[alexstyl]

That is probably sorted by updating the version of the library.

If you want to contribute, you can try it locally, see if it crashes and open a PR with the updated version.

[ddrb56]

But compose unstyled uses that flag and it will inevitably crash even if I update the compose version. See here:

compose-unstyled/composeunstyled-primitives/src/commonMain/kotlin/com/composeunstyled/LongClickable.kt

Lines 71 to 78 in 4d6a0f3

	@OptIn(ExperimentalFoundationApi::class)
	private val coroutineStartForCurrentDispatchBehavior
	get() =
	if (isDetectTapGesturesImmediateCoroutineDispatchEnabled) {
	CoroutineStart.UNDISPATCHED
	} else {
	CoroutineStart.DEFAULT
	}

compose-unstyled/composeunstyled-primitives/src/commonMain/kotlin/com/composeunstyled/LongClickable.kt

Lines 135 to 147 in 4d6a0f3

	suspend fun PointerInputScope.detectTapGestures(
	pass: PointerEventPass = PointerEventPass.Main,
	onLongPress: ((Offset) -> Unit),
	) = coroutineScope {
	// special signal to indicate to the sending side that it shouldn't intercept and consume
	// cancel/up events as we're only require down events
	val pressScope = PressGestureScopeImpl(this@detectTapGestures)
	awaitEachGesture {
	val down = awaitFirstDown(pass = pass)
	if (down.type != PointerType.Touch && down.type != PointerType.Stylus) {
	return@awaitEachGesture
	}
	var resetJob = launch(start = coroutineStartForCurrentDispatchBehavior) { pressScope.reset() }

I checked the default implementation of compose for detectTapGesture and they use CoroutineStart.UNDISPATCHED by default. Maybe doing the same will fix the issue. Is there a specific reason for using CoroutineStart.DEFAULT or should i create a PR with these changes?

[alexstyl]

IIRC the LongClickable is taken from Compose itself as it was an experimental API.

Since those change over time, I found that keeping a copy in the library mitigates against API changes from Compose.

Is the api we use in compose still experimental? If yes, try to copy over the new version of LongClickable.

If it is not experimental anymore, it should be safe to use the Compose one instead.

[ddrb56]

I couldn't find a LongClickable implementation in compose. It looks like they centralized it into one function

suspend fun PointerInputScope.detectTapGestures(
    onDoubleTap: ((Offset) -> Unit)? = null,
    onLongPress: ((Offset) -> Unit)? = null,
    onPress: suspend PressGestureScope.(Offset) -> Unit = NoPressGesture,
    onTap: ((Offset) -> Unit)? = null,
)

And the interceptingLongClickable modifier used for tooltips requires PointerEventPass which is no longer available here.