Skip to content

Commit f41bb15

Browse files
committed
docs(sample): drop stale merged-issue references from screen comments
1 parent f3a7b08 commit f41bb15

6 files changed

Lines changed: 17 additions & 18 deletions

File tree

sample/shared/src/commonMain/kotlin/io/github/compose/jindong/sample/screens/PresetGalleryScreen.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,8 @@ fun PresetGalleryScreen(modifier: Modifier = Modifier) {
9595
}
9696
}
9797

98-
// VIBRATION PATH (stale pre-#84; see SingleHapticScreen for the rationale). Each preset's literal
99-
// events are replayed serially via the Compose DSL; the timeline cards above are always live.
98+
// Each preset's literal events are replayed serially via the Compose DSL; the timeline cards above
99+
// are always live.
100100
val current = remember(playName) { presets.firstOrNull { it.name == playName } }
101101
if (current != null) {
102102
Jindong(playTrigger, playName) {

sample/shared/src/commonMain/kotlin/io/github/compose/jindong/sample/screens/ReactiveScreen.kt

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -64,13 +64,9 @@ import io.github.compose.jindong.sample.theme.JindongTheme
6464
import kotlin.math.roundToLong
6565

6666
/**
67-
* Reactive / State-driven (handoff 07): the one differentiator moving a control re-fires the
67+
* Reactive / State-driven (handoff 07): the one differentiator, moving a control re-fires the
6868
* pattern with no Play button, and the pattern itself changes with state. This screen doubles as a
6969
* regression oracle: each card's Expected/Actual proves whether the live path tracks the controls.
70-
*
71-
* NOTE: pre-#84 the VIBRATION (the actual buzz from `Jindong`) is the bug surface — it replays the
72-
* first-compiled pattern. The TIMELINE here stays live (it never touches the buggy remember), so the
73-
* Expected/Actual comparison still reads true; once #84 lands the buzz matches with zero changes.
7470
*/
7571
@Composable
7672
fun ReactiveScreen(modifier: Modifier = Modifier) {
@@ -143,7 +139,8 @@ private fun ThresholdCard() {
143139
},
144140
)
145141

146-
// VIBRATION PATH (stale pre-#84). The card's timeline is live; the buzz self-heals once #84 lands.
142+
// State is a key, so the pattern recompiles and the buzz tracks the controls. The card's timeline
143+
// is driven separately and is always live.
147144
Jindong(rxThresh) {
148145
Haptic(120.ms, HapticIntensity.Custom(intensity))
149146
}
@@ -183,7 +180,8 @@ private fun CountCard() {
183180
},
184181
)
185182

186-
// VIBRATION PATH (stale pre-#84). The card's timeline is live; the buzz self-heals once #84 lands.
183+
// State is a key, so the pattern recompiles and the buzz tracks the controls. The card's timeline
184+
// is driven separately and is always live.
187185
Jindong(rxCount) {
188186
Repeat(rxCount) {
189187
Haptic(60.ms, HapticIntensity.Custom(0.7f))
@@ -240,7 +238,8 @@ private fun MultiInputCard() {
240238
},
241239
)
242240

243-
// VIBRATION PATH (stale pre-#84). The card's timeline is live; the buzz self-heals once #84 lands.
241+
// State is a key, so the pattern recompiles and the buzz tracks the controls. The card's timeline
242+
// is driven separately and is always live.
244243
Jindong(rxDur, rxInt) {
245244
Haptic(rxDur.ms, HapticIntensity.Custom(rxInt))
246245
}

sample/shared/src/commonMain/kotlin/io/github/compose/jindong/sample/screens/RepeatScreen.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,8 +119,8 @@ fun RepeatScreen(modifier: Modifier = Modifier) {
119119
PlayButton(onClick = { playTrigger++ })
120120
}
121121

122-
// VIBRATION PATH (stale pre-#84; see SingleHapticScreen for the rationale). The timeline above is
123-
// always live; this executor call self-heals once #84 lands.
122+
// Explicit-play: playTrigger and the pattern parameters are keys, so Play replays the current
123+
// values. The timeline above is driven separately and is always live.
124124
Jindong(playTrigger, rpCount) {
125125
Repeat(rpCount) {
126126
Haptic(60.ms, HapticIntensity.Custom(UNIT_INTENSITY))

sample/shared/src/commonMain/kotlin/io/github/compose/jindong/sample/screens/RepeatWithIndexScreen.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,8 +151,8 @@ fun RepeatWithIndexScreen(modifier: Modifier = Modifier) {
151151
PlayButton(onClick = { playTrigger++ })
152152
}
153153

154-
// VIBRATION PATH (stale pre-#84; see SingleHapticScreen for the rationale). The timeline above is
155-
// always live; this executor call self-heals once #84 lands.
154+
// Explicit-play: playTrigger and the pattern parameters are keys, so Play replays the current
155+
// values. The timeline above is driven separately and is always live.
156156
Jindong(playTrigger, riCount, riDir) {
157157
RepeatWithIndex(riCount) { i ->
158158
Haptic(70.ms, HapticIntensity.Custom(ramp(i, riCount, riDir)))

sample/shared/src/commonMain/kotlin/io/github/compose/jindong/sample/screens/SingleHapticScreen.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,9 +179,9 @@ fun SingleHapticScreen(modifier: Modifier = Modifier) {
179179
PlayButton(onClick = { playTrigger++ })
180180
}
181181

182-
// VIBRATION PATH: key only on playTrigger so this stays an explicit-play screen (Reactive is the
182+
// Explicit-play: key only on playTrigger, so this stays an explicit-play screen (Reactive is the
183183
// auto-firing one). The block reads live sgDur/resolvedIntensity, so Play always uses the current
184-
// values. The timeline above is driven separately from state and stays live regardless of #84.
184+
// values. The timeline above is driven separately from state and stays live.
185185
Jindong(playTrigger) {
186186
Haptic(sgDur.ms, resolvedIntensity)
187187
}

sample/shared/src/commonMain/kotlin/io/github/compose/jindong/sample/screens/TimingScreen.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,8 +151,8 @@ fun TimingScreen(modifier: Modifier = Modifier) {
151151
PlayButton(onClick = { playTrigger++ }, text = "Play sequence")
152152
}
153153

154-
// VIBRATION PATH (stale pre-#84; see SingleHapticScreen for the rationale). The timeline above is
155-
// always live; this executor call self-heals once #84 lands.
154+
// Explicit-play: playTrigger and the pattern parameters are keys, so Play replays the current
155+
// values. The timeline above is driven separately and is always live.
156156
Jindong(playTrigger, nodes.toList()) {
157157
Sequence {
158158
nodes.toList().forEach { node ->

0 commit comments

Comments
 (0)