Fix create_host_path default value is true

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>

Author: ndeloof

loader/loader_test.go

@@ -3935,3 +3935,22 @@ services:
 	assert.DeepEqual(t, p.Services["string"].Build.NoCacheFilter, types.StringList{"foo"})
 	assert.DeepEqual(t, p.Services["list"].Build.NoCacheFilter, types.StringList{"foo", "bar"})
 }
+
+func TestCreateHostPathDefault(t *testing.T) {
+	p, err := loadYAML(`
+name: no-cache-filter
+services:
+  short:
+    volumes:
+      - /host:/container
+  long:
+    volumes:
+      - type: bind
+        source: /host
+        target: /container
+        bind: {}
+`)
+	assert.NilError(t, err)
+	assert.Check(t, p.Services["short"].Volumes[0].Bind.CreateHostPath == true)
+	assert.Check(t, p.Services["long"].Volumes[0].Bind.CreateHostPath == true)
+}

transform/defaults.go

@@ -29,6 +29,7 @@ func init() {
 	DefaultValues["services.*.ports.*"] = portDefaults
 	DefaultValues["services.*.deploy.resources.reservations.devices.*"] = deviceRequestDefaults
 	DefaultValues["services.*.gpus.*"] = deviceRequestDefaults
+	DefaultValues["services.*.volumes.*.bind"] = defaultVolumeBind
 }
 
 // RegisterDefaultValue registers a custom transformer for the given path pattern

transform/volume.go

@@ -50,3 +50,14 @@ func cleanTarget(target string) string {
 	}
 	return path.Clean(target)
 }
+
+func defaultVolumeBind(data any, p tree.Path, _ bool) (any, error) {
+	bind, ok := data.(map[string]any)
+	if !ok {
+		return data, fmt.Errorf("%s: invalid type %T for service volume bind", p, data)
+	}
+	if _, ok := bind["create_host_path"]; !ok {
+		bind["create_host_path"] = true
+	}
+	return bind, nil
+}