Commit 5ae4abd
authored
ci: build the binary's tests, which nothing did (#67)
`cargo test` did not compile on main. The `sync ls --json` schema test in
`src/main.rs` builds a `SyncEntryStatus` literally, and #61 added a
`sweep` field to that struct without updating it, so the bin test target
failed with E0063.
CI stayed green through all of it, because the workflow runs `--lib` and
three named integration targets and never builds the binary's own tests.
So the gap is not the missing field. The gap is that a test could stop
COMPILING and every check still passed.
FIXING THE COMPILE ERROR THEN EXPOSED A REAL FAILURE, which is the point.
`sync_ls_json_schema_exposes_counts_and_drift` pins the exact JSON of
`fabric sync ls --json`. #61 added `sweep` to that output. The test that
exists to catch a wire-schema change did not catch it, because it had not
run since before the change.
I WATCHED THE NEW CHECK FAIL. `cargo test --bins` failed on the compile
error, then failed again on the schema assertion with `sweep` present on
the left and absent on the right, then passed once the expectation
carried the field. That is the positive control, in this order, on this
machine.
Two changes, and they belong together because either alone leaves the
hole open: the expectation now carries `sweep`, and the workflow now runs
`cargo test --locked --bins`.
Verified on macOS 15 arm64. 12 bin tests pass. Linux is CI's to confirm.
Agent: Silber.fabric1 parent 216bc9d commit 5ae4abd
2 files changed
Lines changed: 9 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
27 | 33 | | |
28 | 34 | | |
29 | 35 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1147 | 1147 | | |
1148 | 1148 | | |
1149 | 1149 | | |
| 1150 | + | |
1150 | 1151 | | |
1151 | 1152 | | |
1152 | 1153 | | |
| |||
1170 | 1171 | | |
1171 | 1172 | | |
1172 | 1173 | | |
1173 | | - | |
| 1174 | + | |
| 1175 | + | |
1174 | 1176 | | |
1175 | 1177 | | |
1176 | 1178 | | |
| |||
0 commit comments