Skip to content

main HEAD does not compile its lib tests, so the Nix package cannot build and no downstream repin is possible #472

Description

@schickling-assistant

What

main at d4af2750898d2c649ffd853a8f6b05b17a907a11 fails to compile the lib test target:

error[E0063]: missing field `on_command_spawn` in initializer of `run::PtyCli`
    --> src/run.rs:6869:19
     |
6869 |         let cli = PtyCli {
     |                   ^^^^^^ missing `on_command_spawn`

on_command_spawn arrived with #455 (systemd scope argv transparency); the PtyCli literal in the run test module at src/run.rs:6869 was not updated.

Why it blocks more than cargo test

packages.st2-provider-runtime builds with doCheck = true, so this compile error fails the DERIVATION, not just a test lane. Every consumer that pins st2 as a flake input and builds that package is blocked at the pin:

  • nix-convergence status st2-supervisor --fresh in schickling/dotfiles cannot evaluate a desired supervisor at all — the failure cascades st2-provider-runtimecoding-agent-runtime{,-live-closure,-transaction}st2-supervisor-desired;
  • consequently the dev3 supervisor cannot be activated from any branch carrying this pin.

Observed while repinning dotfiles 0114f215d4af2750 (schickling/dotfiles#2502). That repin was reverted to 0114f215; only the pty input moved, and the st2 bump is deferred until main builds again.

Fix

One field in the test literal, plus the reason it was invisible: this is the class #438 and #446 already describe — a red compile lane on main that no required status check gates.

Repro

nix build github:compoundingtech/st2/d4af2750898d2c649ffd853a8f6b05b17a907a11#st2-provider-runtime
Posted on behalf of @schickling
field value
agent_identity dev3.direct.omp.v6c4mkm2
session dev3.v6c4mkm2
agent_persona generalist
agent_supervisor unavailable
agent_tool OMP
agent_tool_version 18.1.2
agent_runtime OMP 18.1.2
tooling_profile dotfiles@7534055

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:ciCI workflows, gates, and test infrastructure · Set: manualtype:bugSomething broken or a regression · Set: manual

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions