ASESPRT-783: Fix status for 0 amount contributions

Author: shahrukh-compuco

Civi/Financeextras/Event/Listener/ContributionPaymentUpdatedListener.php

@@ -19,6 +19,7 @@ private static function updateContributionStatus($contributionId) {
     $contribution = \Civi\Api4\Contribution::get(FALSE)
       ->addWhere('id', '=', $contributionId)
       ->addWhere('contribution_status_id:name', 'IN', $allowedStatus)
+      ->addWhere('total_amount', '!=', 0)
       ->execute()
       ->first();
 

tests/phpunit/Civi/Financeextras/ApiWrapper/PaymentTest.php

@@ -28,7 +28,7 @@ public static function setupBeforeClass(): void {
     self::$contribution = ContributionFabricator::fabricate($contributionParams);
   }
 
-  public function setUp() {
+  public function setUp(): void {
   }
 
   public function testMakingPartialPaymentUpdatesContributionToPartiallyPaid(): void {
@@ -57,4 +57,21 @@ public function testMakingFullPaymentUpdatesContributionToCompleted(): void {
     $this->assertEquals('Completed', $contribution['contribution_status']);
   }
 
+  public function testZeroAmountContributionIsCreatedAsCompleted(): void {
+    $contact = ContactFabricator::fabricate();
+    self::$contribution = ContributionFabricator::fabricate([
+      'financial_type_id' => 'Donation',
+      'receive_date' => date('Y-m-d'),
+      'total_amount' => 0.00,
+      'contact_id' => $contact['id'],
+      'payment_instrument_id' => 'Credit Card',
+      'trxn_id' => md5(time()),
+      'currency' => 'GBP',
+    ]);
+
+    $contribution = civicrm_api3('Contribution', 'getSingle', ['id' => self::$contribution['id']]);
+
+    $this->assertEquals('Completed', $contribution['contribution_status']);
+  }
+
 }