Membership renewal contributions not marked "eligible for GA", so not included in report

[TomCrawshaw]

Running Civi 5.11.0 on Drupal 7.65, GiftAid extension 3.4.2. Donations made using Civi forms and Webforms are marked as "Eligible" in the custom field, and subsequently included in the GA report (where appropriate). However, contributions made during the offline membership renewal process are not marked "eligible" and therefore not included in the report; this is presumably because the Civi membership renewal process ("Renewal Payment and Receipt") does not include the GA profile.

Anyone else experienced this problem?

To sidestep this, I have changed the program CRM/Civigiftaid/Utils/GiftAid.php to check that the contribution is either a Membership sub or a donation, instead of checking the "eligible" custom field in:

  if($contribution[$eligibilityFieldCol] == self::DECLARATION_IS_NO) {
    return FALSE;
  }

Anyone see any issues with this?

A belated reply, but, Yes, we are having the same issue, I think.
Drupal 7.69, CiviCRM 5.19.4, GA extension 3.1.0

We started using the extension only last year and recently we noticed that a batch of new-year membership renewals done off line in the office did not show up in the GA report. All had "Yes 4 years" set and the membership dues contribution is set up as eligible for Gift Aid.

I did observe that the Membership->Renew pathway does not include the Gift Aid panel that is in the straight Contribution pathway. (Same with Membership->New.) I thought this was because the extension would automatically recognize that the contact was okay for Gift Aid and the contribution was in the gift-aid definitions. Apparently that does not happen.

We first noticed this with an earlier version of the extension and promptly upgraded to the latest, but the problem remains.

I am not in a position to tweak the code as you have done, so we are left with revisiting every membership renewal contribution and setting the GA in the edit contribution window. Bit tedious.

Am I missing something or doing something wrong?

Edit: Sorry, mis-read your last line, but would still appreciate any insights.

[jamienovick]

@rsbroughton @TomCrawshaw -

"Profiles" cannot be added to CiviCRM admin screens. As such in v3.1 we have added some logic such that:

If either:

1. the membership or event registration includes a line item with a financial type or
2. the whole contribution financial type
3. is one that is eligible for gift aid

then the extension sets the "is eligible for gift aid" field = Yes on the contribution save.

That will make things easier for Admin and ensure they don't forget.

2. We have also added a warning notification after saving if: The contact does not have a valid Gift Aid declaration stating the following:

This contribution has been automatically marked as Eligible for Gift Aid. This is because the administrator has indicated that it's financial type is Eligible for Gift Aid. However this contact does not have a valid Gift Aid Declaration. You can add one of these here (link to contact gift aid declaration tab).

As such you may need to check whether:

a) The financial type(s) are marked as eligible for gift aid in the gift aid settings
b) The contacts in question have a valid gift aid declaration.

Best

Thanks Jamie. That may explain it. Both a) and b) were set correctly but I think they were all processed with V3.0.2 of the extension. I'll check again now that we have upgraded to V3.1.0
Thanks.