net: phy: realtek: RTL8211F: Update the LED config apply logic

vraevsky · vraevsky · commit f8fd02287eb5 · 2026-03-17T13:07:32.000+02:00
1) Apply the LED config after genphy_soft_reset(phydev);
2) Use the U-Boot defaults if unable to apply LEDs settings
   from device tree.

Signed-off-by: Valentin Raevsky &lt;valentin@compulab.co.il&gt;
diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c
@@ -502,14 +502,16 @@ static int rtl8211f_config_init(struct phy_device *phydev)
 		return ret;
 	}
 
-	ret = rtl8211f_config_leds(phydev);
-	if (ret < 0) {
+	ret  = genphy_soft_reset(phydev);
+
+	if ( rtl8211f_config_leds(phydev) < 0 ) {
 		dev_warn(dev, "Unable to apply LEDs settings from Device Tree, use defaults\n");
+		phy_write_paged(phydev, 0xd04, RTL8211F_LCR, 0x2d7b);
 	}
 	dev_dbg(dev, "Read LCR (LED Control Register): 0x%04x\n",
 		(unsigned int)phy_read_paged(phydev, 0xd04, RTL8211F_LCR));
 
-	return genphy_soft_reset(phydev);
+	return ret;
 }
 
 static int rtl821x_suspend(struct phy_device *phydev)

Original file line number	Diff line number	Diff line change
`@@ -502,14 +502,16 @@ static int rtl8211f_config_init(struct phy_device *phydev)`
`502`	`502`	`return ret;`
`503`	`503`	`}`
`504`	`504`
`505`		`- ret = rtl8211f_config_leds(phydev);`
`506`		`- if (ret < 0) {`
	`505`	`+ ret = genphy_soft_reset(phydev);`
	`506`	`+`
	`507`	`+ if ( rtl8211f_config_leds(phydev) < 0 ) {`
`507`	`508`	`dev_warn(dev, "Unable to apply LEDs settings from Device Tree, use defaults\n");`
	`509`	`+ phy_write_paged(phydev, 0xd04, RTL8211F_LCR, 0x2d7b);`
`508`	`510`	`}`
`509`	`511`	`dev_dbg(dev, "Read LCR (LED Control Register): 0x%04x\n",`
`510`	`512`	`(unsigned int)phy_read_paged(phydev, 0xd04, RTL8211F_LCR));`
`511`	`513`
`512`		`- return genphy_soft_reset(phydev);`
	`514`	`+ return ret;`
`513`	`515`	`}`
`514`	`516`
`515`	`517`	`static int rtl821x_suspend(struct phy_device *phydev)`